Fix favorite sign-in copy + text contrast #88

Merged

ilia merged 3 commits from fix/favorite-signin-copy-contrast into master 2026-08-05 09:42:58 -05:00

Conversation 0 Commits 3 Files Changed 18

+207 -141

ilia commented 2026-08-05 09:33:03 -05:00

Owner

Copy Link

Copy Source

Summary

• Logged-out heart shows favorites sign-in messaging (not report copy)
• Shared SignInRequiredDialog with favorite | report reason
• Replace misplaced text-secondary (pale theme wash) with text-foreground / text-primary across auth dialogs, menus, upload, login pages
• E2e: viewer.favorite-signin.spec.ts

Test plan

• Logged out → open photo → heart → dialog mentions favorites, not report
• Logged out → flag → dialog still mentions report
• Labels/menus readable in light mode (no near-white text)
• CI e2e green

## Summary - Logged-out heart shows favorites sign-in messaging (not report copy) - Shared `SignInRequiredDialog` with `favorite` | `report` reason - Replace misplaced `text-secondary` (pale theme wash) with `text-foreground` / `text-primary` across auth dialogs, menus, upload, login pages - E2e: `viewer.favorite-signin.spec.ts` ## Test plan - [ ] Logged out → open photo → heart → dialog mentions favorites, not report - [ ] Logged out → flag → dialog still mentions report - [ ] Labels/menus readable in light mode (no near-white text) - [ ] CI e2e green

ilia added 1 commit 2026-08-05 09:33:04 -05:00

Fix favorite sign-in copy and pale text-secondary contrast. ... 0b4162de5f

Logged-out favorite/report share a reason-aware SignInRequiredDialog so
favorites no longer show report messaging. Replace misplaced text-secondary
(light wash token) with foreground/primary on labels, auth, and menus.

ilia added 1 commit 2026-08-05 09:36:57 -05:00

ci: re-run e2e after DEV deploy of favorite/contrast fix fbe3e41f7b

ilia added 1 commit 2026-08-05 09:38:41 -05:00

e2e: exercise favorite sign-in via photo viewer path 4b9471679c

ilia scheduled this pull request to auto merge when all checks succeed 2026-08-05 09:40:56 -05:00

ilia merged commit dae28e6008 into master 2026-08-05 09:42:58 -05:00

ilia deleted branch fix/favorite-signin-copy-contrast 2026-08-05 09:42:58 -05:00

ilia referenced this issue from a commit 2026-08-05 09:43:00 -05:00

Merge pull request 'Fix favorite sign-in copy + text contrast' (#88) from fix/favorite-signin-copy-contrast into master

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

ira (Ira) noam tanyar09 ilia (Ilia)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: ilia/punimtag#88