ilia/punimtag
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Identify chip contrast + admin token opacity #106

Merged
ilia merged 1 commits from fix/overlay-contrast-and-token-opacity into master 2026-08-05 16:20:27 -05:00
Conversation 0 Commits 1 Files Changed 6
+95 -33
ilia commented 2026-08-05 16:15:16 -05:00
Owner
Copy Link
Copy Source

Summary

  • Face hover chip used `bg-white text-foreground` → invisible in dark mode; now navy + white
  • Gallery video play icon same class of bug (theme foreground on white disc)
  • PhotoGrid tooltips aligned to navy/white; tooltip arrow supports `navy`
  • Admin Tailwind theme colors use `color-mix` so `text-foreground/80` etc. actually render
  • e2e smoke guards the bad `bg-white`+`text-foreground` Identify pairing

Test plan

  • admin build
  • Hard-refresh viewer dark mode → hover unidentified face → readable Identify
  • Admin labels using `/80` still readable
  • CI e2e
## Summary - Face hover chip used \`bg-white text-foreground\` → invisible in dark mode; now navy + white - Gallery video play icon same class of bug (theme foreground on white disc) - PhotoGrid tooltips aligned to navy/white; tooltip arrow supports \`navy\` - Admin Tailwind theme colors use \`color-mix\` so \`text-foreground/80\` etc. actually render - e2e smoke guards the bad \`bg-white\`+\`text-foreground\` Identify pairing ## Test plan - [x] admin build - [ ] Hard-refresh viewer dark mode → hover unidentified face → readable Identify - [ ] Admin labels using \`/80\` still readable - [ ] CI e2e
ilia added 1 commit 2026-08-05 16:15:16 -05:00
Fix invisible Identify chip and theme token opacity.
CI / skip-ci-check (pull_request) Successful in 30s
Details
CI / python-lint (pull_request) Successful in 32s
Details
CI / docker-ci (pull_request) Successful in 32s
Details
CI / secret-scan (pull_request) Successful in 37s
Details
CI / e2e (pull_request) Successful in 2m46s
Details
CI / viewer-unit (pull_request) Successful in 3m3s
Details
CI / admin-unit (pull_request) Successful in 3m17s
Details
da31ab50a7
ilia scheduled this pull request to auto merge when all checks succeed 2026-08-05 16:18:26 -05:00
ilia merged commit 68dc896371 into master 2026-08-05 16:20:27 -05:00
ilia deleted branch fix/overlay-contrast-and-token-opacity 2026-08-05 16:20:28 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
ira (Ira) noam tanyar09 ilia (Ilia)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ilia/punimtag#106