Honest CI: fix ruff lint and harden gates

tests/test_cherry_pick.py

@@ -60,7 +60,7 @@ def test_wilson_not_in_auto_channels(cherry_pick):
 
 
 def test_dry_run_pick_count(cherry_pick, export, empty_manifest, tmp_path, monkeypatch):
-    path, manifest = empty_manifest
+    _path, manifest = empty_manifest
     monkeypatch.setattr(cherry_pick, "MANIFEST_PATH", tmp_path / "manifest.json")
     monkeypatch.setattr(cherry_pick, "DEFAULT_EXPORT", export.paths.root)
 

tests/test_coverage_gaps.py

@@ -2,12 +2,11 @@
 
 from __future__ import annotations
 
-import io
 import json
 import urllib.error
 import urllib.request
-import zipfile
 from pathlib import Path
+
 import pytest
 
 
@@ -117,9 +116,10 @@ def test_manifest_post_skips_non_dict_user(api):
 
 
 def test_safe_export_path_rejects_dotdot():
+    from unittest.mock import Mock
+
     import server
     from slack_export import SlackExport
-    from unittest.mock import Mock
 
     root = Path(__file__).resolve().parents[1] / "tests/fixtures/mini-export"
     handler = Mock(spec=server.ReviewHandler)

tests/test_helpers.py

@@ -5,11 +5,16 @@ from __future__ import annotations
 import io
 import json
 import zipfile
-from pathlib import Path
 
 import pytest
 
-from slack_export import SlackExport, load_json, resolve_paths, slack_ts_to_iso, user_display
+from slack_export import (
+    SlackExport,
+    load_json,
+    resolve_paths,
+    slack_ts_to_iso,
+    user_display,
+)
 
 
 def test_slack_ts_to_iso():

tests/test_prepare_export.py

@@ -3,8 +3,6 @@
 from __future__ import annotations
 
 import json
-import shutil
-import sys
 from pathlib import Path
 
 import pytest

tests/test_preset_skips.py

@@ -6,8 +6,6 @@ import importlib.util
 import json
 from pathlib import Path
 
-import pytest
-
 REPO = Path(__file__).resolve().parents[1]
 
 

tests/test_server.py

@@ -2,8 +2,6 @@
 
 from __future__ import annotations
 
-import json
-
 
 def test_health(api):
     data = api["get"]("/api/health")

tests/test_slack_export_extended.py

@@ -3,7 +3,6 @@
 from __future__ import annotations
 
 import json
-from pathlib import Path
 
 import pytest