Add lint, typecheck, and html-validate guardrails

Tooling:
- ESLint 9 flat config (eslint.config.mjs) with three scopes:
  - browser vanilla JS for js/ (no modules, window globals)
  - Node ESM for scripts/
  - typescript-eslint for tests/ and *.ts
- Stylelint with a deliberately minimal "bug-only" ruleset
  (block-no-empty, color-no-invalid-hex, function-no-unknown,
  property-no-unknown, …) — no nags about compact handwritten CSS
- html-validate against index.html (DOCTYPE, accessible names,
  non-redundant ARIA roles, valid landmark usage)
- TypeScript --noEmit strict on playwright.config.ts + tests/*.ts

npm scripts:
- lint        — parallel run of lint:js, lint:css, lint:html (~3s)
- lint:js{,:fix}, lint:css{,:fix}, lint:html
- typecheck   — tsc --noEmit
- check       — lint + typecheck + test in parallel (CI entry point)

Fixes uncovered by the new checks:
- js/app.js: drop unused `activeTimers`, drop unused `t` lookup in
  refreshTreeRow, switch `activeTags` let→const, replace empty
  `catch(_)` blocks with parameter-less catch + intent comment
- js/data.js: drop unused index arg in renderExperience
- index.html: uppercase DOCTYPE, drop redundant role="banner" /
  role="contentinfo" on <header>/<footer>, add aria-labels on icon-only
  Stop / Reset buttons, add role="group" to the tag bar so its
  aria-label is valid, add explicit type="button" everywhere
- tests/portfolio.spec.ts: landmark test now uses getByRole() rather
  than the explicit [role="banner"] attribute selector

Housekeeping:
- .gitignore picks up .eslintcache / .stylelintcache / *.tsbuildinfo
- README documents the lint + check toolchain

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Builder
2026-05-11 23:06:42 -04:00
co-authored by Cursor
parent b596b2d608
commit 6f897fafb9
12 changed files with 3447 additions and 29 deletions
+5 -7
View File
@@ -13,7 +13,6 @@
// Test state: idle | running | passed | skipped
const state = Object.fromEntries(tests.map(t=>[t.id, { status: t.skip ? 'skipped' : t.fail ? 'failed' : 'idle', runtime:0 }]));
let isRunningAll = false;
let activeTimers = [];
const headed = () => $('#headed').checked;
const getWorkers = () => Math.max(1, parseInt($('#workers').value, 10) || 1);
@@ -24,7 +23,7 @@
return m ? m[1] : null;
}
function writeSpecCookie(v){
try { document.cookie = `spec=${v}; path=/; max-age=31536000; SameSite=Lax`; } catch(_) {}
try { document.cookie = `spec=${v}; path=/; max-age=31536000; SameSite=Lax`; } catch { /* cookies disabled */ }
}
function getSpec(id){ return specs.find(s => s.id === id) || specs[0]; }
function specCountFor(id){ return tests.filter(t => t.spec === id).length; }
@@ -122,7 +121,6 @@
</div>`;
}
function refreshTreeRow(id){
const t = tests.find(x=>x.id===id);
const s = state[id];
const row = $(`.test[data-id="${id}"]`);
if (!row) return;
@@ -141,7 +139,7 @@
// chip that expands them inline on click. Keeps the sidebar visual mass
// small until a visitor needs the full registry.
const VISIBLE_TAGS = 6;
let activeTags = new Set();
const activeTags = new Set();
function renderTagBar(){
const bar = $('#tag-bar');
const all = Array.isArray(data.tags) ? data.tags : [];
@@ -628,10 +626,10 @@
}
function utf8ByteLength(str){
if (typeof TextEncoder !== 'undefined') {
try { return new TextEncoder().encode(str).length; } catch (_) {}
try { return new TextEncoder().encode(str).length; } catch { /* fall through */ }
}
try { return encodeURIComponent(str).replace(/%../g, 'x').length; }
catch (_) { return str.length * 4; }
catch { return str.length * 4; }
}
/** Resolve list mount (handles older HTML ids + creates a node under `.network-pane` if needed). */
@@ -780,7 +778,7 @@
return m ? m[1] : null;
}
function writeThemeCookie(v){
try { document.cookie = `theme=${v}; path=/; max-age=31536000; SameSite=Lax`; } catch(_) {}
try { document.cookie = `theme=${v}; path=/; max-age=31536000; SameSite=Lax`; } catch { /* cookies disabled */ }
}
function initTheme(){
const saved = readThemeCookie() || 'dark';