Merge pull request #321 from swatijadhav/update-contact-links

Update contact links in resume
This commit is contained in:
pubkey 2018-12-18 10:38:37 +01:00 committed by GitHub
commit dbf8aadcab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 65 additions and 35 deletions

View File

@ -53,7 +53,7 @@
<a
class="section-link"
:href="'mailto:' + person.contact.email">
:href="contactLinks.email">
<i class="section-link__icon material-icons">mail</i>{{ person.contact.email }}
</a>
@ -71,21 +71,21 @@
<a
v-if="person.contact.linkedin"
class="section-link"
:href="'https://linkedin.com/in/' + person.contact.linkedin">
:href="contactLinks.linkedin">
<i class="section-link__icon fa fa-linkedin"></i>{{ person.contact.linkedin }}
</a>
<a
v-if="person.contact.github"
class="section-link"
:href="'https://github.com/' + person.contact.github">
:href="contactLinks.github">
<i class="section-link__icon fa fa-github"></i>{{ person.contact.github }}
</a>
<a
v-if="person.contact.medium"
class="section-link"
:href="'https://medium.com/@' + person.contact.medium">
:href="contactLinks.medium">
<i class="section-link__icon fa fa-medium"></i>{{ person.contact.medium }}
</a>
</div>

View File

@ -22,7 +22,7 @@
{{ person.knowledge }}
</div>
<a :href="'mailto:' + person.contact.email">
<a :href="contactLinks.email">
<div class="block-marged txt-full-white">
{{ person.contact.email }}
</div>
@ -43,7 +43,7 @@
</a>
<a v-if="person.contact.github"
:href="'https://github.com/' + person.contact.github"
:href="contactLinks.github"
class="external-link">
<i class="fa fa-github contact-icon"></i>
@ -53,7 +53,7 @@
</a>
<a v-if="person.contact.codefights"
:href="'https://codefights.com/profile/' + person.contact.codefights"
:href="contactLinks.codefights"
class="external-link">
<svg width="20" height="20" viewBox="0 0 24 24"
@ -68,7 +68,7 @@
</a>
<a v-if="person.contact.medium"
:href="'https://medium.com/@' + person.contact.medium"
:href="contactLinks.medium"
class="external-link">
<i class="fab fa-medium contact-icon"></i>
<span class="block-marged txt-full-white">

View File

@ -26,11 +26,11 @@
<table>
<tr>
<td><i class="fa fa-envelope" aria-hidden="true"></i></td>
<td><a :href="'mailto:'+person.contact.email">{{person.contact.email}}</a></td>
<td><a :href="contactLinks.email">{{person.contact.email}}</a></td>
</tr>
<tr>
<td><i class="fa fa-phone" aria-hidden="true"></i></td>
<td><a :href="'tel:'+person.contact.phone">{{person.contact.phone}}</a></td>
<td><a :href="contactLinks.phone">{{person.contact.phone}}</a></td>
</tr>
<tr>
<td><i class="fa fa-home" aria-hidden="true"></i></td>
@ -42,7 +42,7 @@
</tr>
<tr v-if="person.contact.github">
<td><i class="fa fa-github" aria-hidden="true"></i></td>
<td><a :href="'https://github.com/'+person.contact.github">https://github.com/{{person.contact.github}}</a></td>
<td><a :href="contactLinks.github">{{contactLinks.github}}</a></td>
</tr>
</table>
</div>

View File

@ -25,11 +25,11 @@
<h3>{{ lang.contact }}</h3>
<table>
<tr>
<td><a :href="'mailto:'+person.contact.email">{{person.contact.email}}</a></td>
<td><a :href="contactLinks.email">{{person.contact.email}}</a></td>
<td><i class="fa fa-envelope" aria-hidden="true"></i></td>
</tr>
<tr>
<td><a :href="'tel:'+person.contact.phone">{{person.contact.phone}}</a></td>
<td><a :href="contactLinks.phone">{{person.contact.phone}}</a></td>
<td><i class="fa fa-phone" aria-hidden="true"></i></td>
</tr>
<tr>
@ -41,7 +41,7 @@
<td><i class="fa fa-globe" aria-hidden="true"></i></td>
</tr>
<tr v-if="person.contact.github">
<td><a :href="'https://github.com/'+person.contact.github">https://github.com/{{person.contact.github}}</a></td>
<td><a :href="contactLinks.github">{{contactLinks.github}}</a></td>
<td><i class="fa fa-github" aria-hidden="true"></i></td>
</tr>
</table>

View File

@ -30,7 +30,7 @@
</div>
</div>
<a :href="'tel:'+person.contact.phone">
<a :href="contactLinks.phone">
<div class="item">
<div class="icon">
<i class="material-icons">phone</i>
@ -41,7 +41,7 @@
</div>
</a>
<a :href="'mailto:'+person.contact.email">
<a :href="contactLinks.email">
<div class="item">
<div class="icon">
<i class="material-icons">email</i>
@ -52,7 +52,7 @@
</div>
</a>
<a v-if="person.contact.github" :href="'https://github.com/'+person.contact.github" target="_blank">
<a v-if="person.contact.github" :href="contactLinks.github" target="_blank">
<div class="item">
<div class="icon">
<i class="fa fa-github"></i>

View File

@ -56,17 +56,17 @@
</div>
<div class="contact">
<h3>{{ lang.contact }}</h3>
<a :href="'mailto:'+person.contact.email"> {{person.contact.email}}</a>
<a :href="contactLinks.email"> {{person.contact.email}}</a>
<span>;&nbsp;</span>
<a :href="'tel:'+person.contact.phone">{{person.contact.phone}}</a>
<a :href="contactLinks.phone">{{person.contact.phone}}</a>
<span>;&nbsp;</span>
<span>{{person.contact.street}}, {{person.contact.city}}</span>
<span>;&nbsp;</span>
<a v-if="person.contact.website" :href="person.contact.website">
{{person.contact.website}}</a>
<span v-if="person.contact.website">;&nbsp;</span>
<a v-if="person.contact.github" :href="'https://github.com/'+person.contact.github">
https://github.com/{{person.contact.github}}</a>
<a v-if="person.contact.github" :href="contactLinks.github">
{{contactLinks.github}}</a>
</div>
</div>
</div>

View File

@ -13,7 +13,7 @@ function getVueOptions (name) {
data () {
return {
person: yaml.load(PERSON),
terms: terms
terms: terms,
};
},
computed: {
@ -23,14 +23,44 @@ function getVueOptions (name) {
// overwrite non-set fields with default lang
Object.keys(defaultLang)
.filter(k => !useLang[k])
.forEach(k => {
console.log(k);
useLang[k] = defaultLang[k];
});
.filter(k => !useLang[k])
.forEach(k => {
console.log(k);
useLang[k] = defaultLang[k];
});
return useLang;
}
},
contactLinks() {
const links = {};
if(this.person.contact.github) {
links.github = `https://github.com/${this.person.contact.github}`;
}
if(this.person.contact.codefights) {
links.codefights = `https://codefights.com/profile/${this.person.contact.codefights}`;
}
if(this.person.contact.medium) {
links.medium = `https://medium.com/@${this.person.contact.medium}`;
}
if(this.person.contact.email) {
links.email = `mailto:${this.person.contact.email}`;
}
if(this.person.contact.linkedin) {
links.linkedin = `https://linkedin.com/in/${this.person.contact.linkedin}`;
}
if(this.person.contact.phone) {
links.phone = `tel:${this.person.contact.phone}`;
}
return links;
},
}
};
return opt;

View File

@ -9,7 +9,7 @@
<i class="fa fa-envelope" aria-hidden="true"></i> {{person.contact.email}}</a></span>
<span id="phone"><i class='fa fa-phone-square' aria-hidden="true"></i> {{person.contact.phone}}</span>
<span v-if="person.contact.website" id="website"><a :href='person.contact.website'><i class="fa fa-home" aria-hidden="true"></i> {{person.contact.website}}</a></span>
<span v-if="person.contact.github" id="github"><a :href='"https://github.com/" + person.contact.github'><i class="fa fa-github" aria-hidden="true"></i> {{person.contact.github}}</a></span>
<span v-if="person.contact.github" id="github"><a :href='contactLinks.github'><i class="fa fa-github" aria-hidden="true"></i> {{person.contact.github}}</a></span>
</div>
</div>
<div id="header-right">

View File

@ -17,7 +17,7 @@
<div class="contact">
<h3>{{ lang.contact }}</h3>
<div class="contact-row">
<a :href="'mailto:'+person.contact.email">{{person.contact.email}}</a>
<a :href="contactLinks.email">{{person.contact.email}}</a>
</div>
<div class="contact-row dots">
<i class="fa fa-circle" aria-hidden="true"></i>
@ -25,7 +25,7 @@
<i class="fa fa-circle" aria-hidden="true"></i>
</div>
<div class="contact-row">
<a href="'tel:'+person.contact.phone">{{person.contact.phone}}</a>
<a href="contactLinks.phone">{{person.contact.phone}}</a>
</div>
<div class="contact-row dots">
<i class="fa fa-circle" aria-hidden="true"></i>
@ -41,7 +41,7 @@
<i class="fa fa-circle" aria-hidden="true"></i>
</div>
<div class="contact-row">
<a :href="'https://github.com/'+person.contact.github">https://github.com/{{person.contact.github}}</a>
<a :href="contactLinks.github">{{contactLinks.github}}</a>
</div>
</div>
</div>

View File

@ -17,7 +17,7 @@
<div class="contact">
<h3>{{ lang.contact }}</h3>
<div class="contact-row">
<a :href="'mailto:'+person.contact.email">{{person.contact.email}}</a>
<a :href="contactLinks.email">{{person.contact.email}}</a>
</div>
<div class="contact-row dots">
<i class="fa fa-circle" aria-hidden="true"></i>
@ -25,7 +25,7 @@
<i class="fa fa-circle" aria-hidden="true"></i>
</div>
<div class="contact-row">
<a :href="'tel:'+person.contact.phone">{{person.contact.phone}}</a>
<a :href="contactLinks.phone">{{person.contact.phone}}</a>
</div>
<div class="contact-row dots">
<i class="fa fa-circle" aria-hidden="true"></i>
@ -41,7 +41,7 @@
<i class="fa fa-circle" aria-hidden="true"></i>
</div>
<div v-if="person.contact.github" class="contact-row">
<a :href="'https://github.com/'+person.contact.github">https://github.com/{{person.contact.github}}</a>
<a :href="contactLinks.github">{{contactLinks.github}}</a>
</div>
</div>
</div>