From 4391b219dc48e029d61b36f924f9b7ffefc1e9c8 Mon Sep 17 00:00:00 2001 From: salomonelli Date: Thu, 19 Oct 2017 00:15:02 +0200 Subject: [PATCH] CHANGE use check-node-version --- README.md | 2 +- build/build.js | 2 -- build/check-versions.js | 48 ----------------------------------------- build/dev-server.js | 2 -- package.json | 7 ++---- 5 files changed, 3 insertions(+), 58 deletions(-) delete mode 100755 build/check-versions.js diff --git a/README.md b/README.md index 0823bab..313bb5c 100755 --- a/README.md +++ b/README.md @@ -30,7 +30,7 @@ ## How to use -best-resume-ever requires at least node v.8.5. +best-resume-ever requires at least node v.8.0.0. 1. Clone this repository. diff --git a/build/build.js b/build/build.js index 6b8add1..1191c2e 100755 --- a/build/build.js +++ b/build/build.js @@ -1,5 +1,3 @@ -require('./check-versions')() - process.env.NODE_ENV = 'production' var ora = require('ora') diff --git a/build/check-versions.js b/build/check-versions.js deleted file mode 100755 index 100f3a0..0000000 --- a/build/check-versions.js +++ /dev/null @@ -1,48 +0,0 @@ -var chalk = require('chalk') -var semver = require('semver') -var packageConfig = require('../package.json') -var shell = require('shelljs') -function exec (cmd) { - return require('child_process').execSync(cmd).toString().trim() -} - -var versionRequirements = [ - { - name: 'node', - currentVersion: semver.clean(process.version), - versionRequirement: packageConfig.engines.node - }, -] - -if (shell.which('npm')) { - versionRequirements.push({ - name: 'npm', - currentVersion: exec('npm --version'), - versionRequirement: packageConfig.engines.npm - }) -} - -module.exports = function () { - var warnings = [] - for (var i = 0; i < versionRequirements.length; i++) { - var mod = versionRequirements[i] - if (!semver.satisfies(mod.currentVersion, mod.versionRequirement)) { - warnings.push(mod.name + ': ' + - chalk.red(mod.currentVersion) + ' should be ' + - chalk.green(mod.versionRequirement) - ) - } - } - - if (warnings.length) { - console.log('') - console.log(chalk.yellow('To use this template, you must update following to modules:')) - console.log() - for (var i = 0; i < warnings.length; i++) { - var warning = warnings[i] - console.log(' ' + warning) - } - console.log() - process.exit(1) - } -} diff --git a/build/dev-server.js b/build/dev-server.js index f4d41e3..1af13bd 100755 --- a/build/dev-server.js +++ b/build/dev-server.js @@ -1,5 +1,3 @@ -require('./check-versions')() - var config = require('../config') if (!process.env.NODE_ENV) { process.env.NODE_ENV = JSON.parse(config.dev.env.NODE_ENV) diff --git a/package.json b/package.json index 7b27db5..fb2c9b9 100755 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ }, "scripts": { "dev": "node build/dev-server.js", - "build": "node build/build.js", + "predev": "check-node-version --node \">= 8.0.0\"", "start": "node build/dev-server.js", "pdf": "node node/app.js", "preview": "node node/preview.js", @@ -41,6 +41,7 @@ "babel-preset-stage-2": "^6.22.0", "babel-register": "^6.26.0", "chalk": "^1.1.3", + "check-node-version": "^2.1.0", "concurrently": "^3.5.0", "connect-history-api-fallback": "^1.3.0", "copy-webpack-plugin": "^4.0.1", @@ -93,9 +94,5 @@ "webpack-dev-middleware": "^1.12.0", "webpack-hot-middleware": "^2.19.1", "webpack-merge": "^4.1.0" - }, - "engines": { - "node": ">= 8.0.0", - "npm": ">= 5.0.0" } }