ilia/punimtag
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Person merge API + Modify People UI #95

Merged
ilia merged 2 commits from feature/person-merge into master 2026-08-05 11:41:20 -05:00
Conversation 0 Commits 2 Files Changed 7
+426 -4
ilia commented 2026-08-05 11:31:51 -05:00
Owner
Copy Link
Copy Source

Summary

  • POST /api/v1/people/{keep_id}/merge with { merge_ids: [...] } — moves faces, video linkages (dedupe), match decisions; rebuilds person_encodings; deletes sources.
  • Modify People: checkboxes + confirm dialog to merge into the selected keep person.
  • Tests in TestPeopleMerge; accuracy status updated.

Test plan

  • CI green (includes TestPeopleMerge)
  • On DEV: pick keep person, check a duplicate, Merge — faces/videos land on keep; source gone
  • Self-merge / missing id return 400/404

Depends on / stacks after scrub #94 (independent of secrets scrub).

## Summary - `POST /api/v1/people/{keep_id}/merge` with `{ merge_ids: [...] }` — moves faces, video linkages (dedupe), match decisions; rebuilds `person_encodings`; deletes sources. - Modify People: checkboxes + confirm dialog to merge into the selected keep person. - Tests in `TestPeopleMerge`; accuracy status updated. ## Test plan - [ ] CI green (includes `TestPeopleMerge`) - [ ] On DEV: pick keep person, check a duplicate, Merge — faces/videos land on keep; source gone - [ ] Self-merge / missing id return 400/404 Depends on / stacks after scrub #94 (independent of secrets scrub).
ilia added 1 commit 2026-08-05 11:31:53 -05:00
Add Immich-style person merge API and Modify UI.
CI / skip-ci-check (pull_request) Successful in 32s
Details
CI / python-lint (pull_request) Successful in 36s
Details
CI / docker-ci (pull_request) Successful in 36s
Details
CI / secret-scan (pull_request) Successful in 47s
Details
CI / admin-unit (pull_request) Successful in 1m27s
Details
CI / viewer-unit (pull_request) Successful in 3m53s
Details
CI / e2e (pull_request) Successful in 3m5s
Details
3b9cd12e20 
POST /people/{keep_id}/merge reassigns faces, videos, and match
decisions, rebuilds encodings, then deletes sources so strict
Auto-Match thresholds stay recoverable.
ilia added 1 commit 2026-08-05 11:32:02 -05:00
Note person merge shipped; Phase 6 remains cluster-name work.
CI / skip-ci-check (pull_request) Successful in 35s
Details
CI / docker-ci (pull_request) Successful in 34s
Details
CI / secret-scan (pull_request) Successful in 41s
Details
CI / python-lint (pull_request) Successful in 38s
Details
CI / admin-unit (pull_request) Successful in 57s
Details
CI / viewer-unit (pull_request) Successful in 1m34s
Details
CI / e2e (pull_request) Successful in 4m46s
Details
39c36a68e2
ilia scheduled this pull request to auto merge when all checks succeed 2026-08-05 11:39:18 -05:00
ilia merged commit 3004ecd9e0 into master 2026-08-05 11:41:20 -05:00
ilia deleted branch feature/person-merge 2026-08-05 11:41:20 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
ira (Ira) noam tanyar09 ilia (Ilia)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ilia/punimtag#95