ilia/punimtag
1
1
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

test: timing budgets + CI hardening (artifact v3 pin, npm cache retry) #69

Merged
ilia merged 1 commits from test/timing-budgets-ci-hardening into dev 2026-07-15 08:03:20 -05:00
Conversation 0 Commits 1 Files Changed 22 +155 -6
ilia commented 2026-07-15 07:57:01 -05:00
Owner
Copy Link

Closes three items from the outstanding e2e/CI gap list:

  • Timing budgets: timings.measure() only ever recorded durations for
    the (still-unwired) Pushgateway export — nothing failed CI when a step
    got slow. Adds e2e/timing-budgets.ts (expectWithinBudget + shared
    BUDGET_MS buckets) and wires it into every measure() call site across
    the suite. Mail-wait steps are deliberately left unbudgeted (external
    mail-trap delivery latency, not a code performance signal).

  • actions/upload-artifact@v4 doesn't work against this Gitea/act
    runner's artifact backend — pinned to v3 for the e2e failure-report
    upload.

  • npm cache corruption retry: the shared act_runner npm cache has
    corrupted platform-native tarballs before (@next/swc-linux-x64-musl)
    and reds viewer-unit/admin-unit/e2e with no product bug involved.
    All three npm ci steps now retry once after npm cache clean --force
    on first failure.

ROADMAP.md / e2e/README.md updated to reflect all three as closed.

Test plan

  • npx tsc --noEmit clean in e2e/
  • Full local Playwright suite green against DEV (37 passed, 6 skipped,
    no budget-assertion failures)
  • CI green (viewer-unit, admin-unit, e2e)
Closes three items from the outstanding e2e/CI gap list: - **Timing budgets**: `timings.measure()` only ever recorded durations for the (still-unwired) Pushgateway export — nothing failed CI when a step got slow. Adds `e2e/timing-budgets.ts` (`expectWithinBudget` + shared `BUDGET_MS` buckets) and wires it into every `measure()` call site across the suite. Mail-wait steps are deliberately left unbudgeted (external mail-trap delivery latency, not a code performance signal). - **`actions/upload-artifact@v4`** doesn't work against this Gitea/act runner's artifact backend — pinned to v3 for the e2e failure-report upload. - **npm cache corruption retry**: the shared act_runner npm cache has corrupted platform-native tarballs before (`@next/swc-linux-x64-musl`) and reds `viewer-unit`/`admin-unit`/`e2e` with no product bug involved. All three `npm ci` steps now retry once after `npm cache clean --force` on first failure. ROADMAP.md / e2e/README.md updated to reflect all three as closed. ## Test plan - [x] `npx tsc --noEmit` clean in `e2e/` - [x] Full local Playwright suite green against DEV (37 passed, 6 skipped, no budget-assertion failures) - [ ] CI green (viewer-unit, admin-unit, e2e)
ilia added 1 commit 2026-07-15 07:57:01 -05:00
test: timing budgets + CI hardening (artifact v3 pin, npm cache retry)
All checks were successful
CI / skip-ci-check (pull_request) Successful in 5s
Details
CI / docker-ci (pull_request) Successful in 7s
Details
CI / secret-scan (pull_request) Successful in 12s
Details
CI / viewer-unit (pull_request) Successful in 1m29s
Details
CI / e2e (pull_request) Successful in 4m8s
Details
CI / admin-unit (pull_request) Successful in 4m24s
Details
c0c997f796 
Closes three items from the outstanding e2e/CI gap list:

- Timing budgets: timings.measure() only ever recorded durations for the
  (still-unwired) Pushgateway export — nothing failed CI when a step got
  slow. Add e2e/timing-budgets.ts (expectWithinBudget + shared BUDGET_MS
  buckets) and wire it into every measure() call site across the suite.
  Mail-wait steps are deliberately left unbudgeted (external mail-trap
  delivery latency, not a code performance signal).

- actions/upload-artifact@v4 doesn't work against this Gitea/act runner's
  artifact backend — pin to v3 for the e2e failure-report upload.

- Shared act_runner npm cache has corrupted platform-native tarballs before
  (@next/swc-linux-x64-musl) and reds viewer-unit/admin-unit/e2e with no
  product bug involved. All three npm ci steps now retry once after
  `npm cache clean --force` on first failure.

Verified: full local suite green against DEV (37 passed, 6 skipped, no
budget assertion failures) before wiring into CI.
ilia merged commit da4fc72807 into dev 2026-07-15 08:03:20 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ira noam tanyar09 ilia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ilia/punimtag#69
No description provided.
Delete Branch "test/timing-budgets-ci-hardening"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?