Enable Sprint D e2e: API-seeded admin session, un-skip vitals/scroll.
CI / skip-ci-check (pull_request) Successful in 31s
CI / docker-ci (pull_request) Successful in 32s
CI / secret-scan (pull_request) Successful in 36s
CI / python-lint (pull_request) Successful in 34s
CI / admin-unit (pull_request) Successful in 55s
CI / viewer-unit (pull_request) Successful in 1m57s
CI / e2e (pull_request) Failing after 2m42s

Admin review smoke seeds localStorage from FastAPI login instead of the
login form — fixes CI flakes on the shared runner.
This commit is contained in:
2026-08-04 23:13:48 -04:00
parent 7bcf787d85
commit db30ba9de9
3 changed files with 30 additions and 8 deletions
+28 -6
View File
@@ -1,28 +1,50 @@
import { z } from 'zod';
import { test, expect } from '../fixtures';
import { AdminLoginPage } from '../pages/AdminLoginPage';
import { BUDGET_MS, expectWithinBudget } from '../timing-budgets';
import { DEFAULT_ADMIN_BASE_URL } from '../env-defaults';
const TokenResponse = z.object({
access_token: z.string().min(1),
refresh_token: z.string().min(1),
});
/**
* FastAPI-admin UI smoke: core review workflows load without error.
* Uses E2E_API_USERNAME/PASSWORD (admin FastAPI user — not NextAuth viewer creds).
*/
test.describe.skip('admin review pages @smoke', () => {
test.describe('admin review pages @smoke', () => {
const adminBaseUrl = process.env.PLAYKIT_ADMIN_BASE_URL || DEFAULT_ADMIN_BASE_URL;
test('identify, auto-match, and approve pages load for admin', async ({
page,
api,
timings,
}) => {
const username = process.env.E2E_API_USERNAME || '';
const password = process.env.E2E_API_PASSWORD || '';
test.skip(!username || !password, 'E2E_API_USERNAME/PASSWORD required for admin UI');
const login = new AdminLoginPage(page, adminBaseUrl);
await timings.measure('admin_login', async () => {
await login.openLogin();
await login.signIn(username, password);
const tokens = await api.post<z.infer<typeof TokenResponse>>('/api/v1/auth/login', {
body: { username, password },
expectedStatus: 200,
schema: TokenResponse,
});
// Seed the admin SPA session (same keys as AuthContext) — more reliable than
// driving the login form on the shared CI runner.
await page.goto(`${adminBaseUrl}/login`);
await page.evaluate(
({ access, refresh }) => {
localStorage.setItem('access_token', access);
localStorage.setItem('refresh_token', refresh);
},
{
access: tokens.data.access_token,
refresh: tokens.data.refresh_token,
},
);
await page.goto(`${adminBaseUrl}/`);
await expect(page.getByRole('button', { name: 'Logout' })).toBeVisible({
timeout: 30_000,
});
+1 -1
View File
@@ -1,7 +1,7 @@
import { test, expect } from '../fixtures';
import { BUDGET_MS, expectWithinBudget } from '../timing-budgets';
test.describe.skip('gallery scroll restore @smoke', () => {
test.describe('gallery scroll restore @smoke', () => {
test('closing photo modal restores scroll position', async ({ page, playkitConfig, timings }) => {
await timings.measure('open_gallery', async () => {
await page.goto(`${playkitConfig.baseUrl}/`);
+1 -1
View File
@@ -7,7 +7,7 @@ import {
readWebVitals,
} from '../web-vitals-budgets';
test.describe.skip('viewer web vitals @smoke', () => {
test.describe('viewer web vitals @smoke', () => {
test.beforeEach(async ({ page }) => {
await installWebVitalsCollector(page);
});