From 4b9471679c02ae3f60cf823a85f823ea5778789f Mon Sep 17 00:00:00 2001 From: ilia Date: Wed, 5 Aug 2026 10:39:05 -0400 Subject: [PATCH] e2e: exercise favorite sign-in via photo viewer path --- e2e/tests/viewer.favorite-signin.spec.ts | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/e2e/tests/viewer.favorite-signin.spec.ts b/e2e/tests/viewer.favorite-signin.spec.ts index 67c3cb3..dd57e17 100644 --- a/e2e/tests/viewer.favorite-signin.spec.ts +++ b/e2e/tests/viewer.favorite-signin.spec.ts @@ -10,22 +10,14 @@ test.describe('favorite sign-in copy @smoke', () => { page.getByRole('button', { name: /Sign in/i }).or(page.getByLabel('Account menu')).first(), ).toBeVisible({ timeout: 20_000 }); - // Prefer grid heart; fall back to opening a photo then using the viewer heart. - const gridFavorite = page.getByRole('button', { name: 'Add to favorites' }).first(); - if (await gridFavorite.isVisible().catch(() => false)) { - await gridFavorite.click({ force: true }); - } else { - const photoButton = page.locator('main .aspect-square button').first(); - await expect(photoButton).toBeVisible({ timeout: 15_000 }); - await photoButton.click(); - await expect(page.getByRole('dialog', { name: /Photo viewer/i })).toBeVisible({ - timeout: 15_000, - }); - await page - .getByRole('dialog', { name: /Photo viewer/i }) - .getByRole('button', { name: 'Add to favorites' }) - .click(); - } + // Open photo viewer (matches the reported bug path) then click the heart. + const photoButton = page.locator('main .aspect-square button').first(); + await expect(photoButton).toBeVisible({ timeout: 15_000 }); + await photoButton.click(); + const viewer = page.getByRole('dialog', { name: /Photo viewer/i }); + await expect(viewer).toBeVisible({ timeout: 15_000 }); + + await viewer.getByRole('button', { name: 'Add to favorites' }).click(); const signInDialog = page.getByRole('dialog').filter({ hasText: 'Sign In Required' }); await expect(signInDialog).toBeVisible({ timeout: 10_000 });