From c7ac31bb99f27496f8aac5c1a921f30180d56fac Mon Sep 17 00:00:00 2001
From: Christian Sarnataro <c.sarnataro@arduino.cc>
Date: Mon, 9 Jan 2023 23:49:52 +0100
Subject: [PATCH] Updated code after code review

---
 README.md                       | 54 +++++++--------------------------
 gitprofile.config.js            | 13 +++++---
 src/components/footer/index.jsx | 29 ++++--------------
 3 files changed, 26 insertions(+), 70 deletions(-)

diff --git a/README.md b/README.md
index e87ac48..dc59939 100644
--- a/README.md
+++ b/README.md
@@ -72,7 +72,6 @@
 ✓ [Education Section](#education)  
 ✓ [Projects Section](#projects)  
 ✓ [Blog Posts Section](#blog-posts)  
-✓ [Custom footer](#custom-footer)
 
 To view a live example, **[click here](https://arifszn.github.io/gitprofile)**.
 
@@ -290,6 +289,17 @@ const config = {
     username: 'arifszn', // to hide blog section, keep it empty
     limit: 5, // How many posts to display. Max is 10.
   },
+  // Display a footer. Supports plain text or HTML. (Optional)
+  footer: {
+    `<p class="font-mono text-sm">
+      Made with <a
+        class="text-primary"
+        href="https://github.com/arifszn/gitprofile"
+        target="_blank"
+        rel="noreferrer"
+      >GitProfile</a>
+      and ❤️</p>`
+  },
   googleAnalytics: {
     id: '', // GA3 tracking id/GA4 tag id UA-XXXXXXXXX-X | G-XXXXXXXXXX
   },
@@ -618,48 +628,6 @@ const config = {
 
 The posts are fetched by [blog.js](https://github.com/arifszn/blog.js).
 
-
-### Custom footer (Optional)
-In the configuration file you can optionally 
-define a custom HTML footer for your page.
-
-If it's not defined, a default footer "Made with GitProfile and ❤️" will be used instead.
-   
-Examples:
-```js
-// gitprofile.config.js
-
-// This is an HTML footer
-const config = {
-  [...]
-  footer: `
-    <p class="font-mono text-sm">
-      Built by <a href="https://www.example.com" class="text-primary" target="_blank" rel="noreferrer">
-        John Doe
-      </a>
-      in <strong>2023</strong>
-      with ❤️ and 
-      <a
-        class="text-primary"
-        href="https://github.com/arifszn/gitprofile"
-        target="_blank"
-        rel="noreferrer"
-      >GitProfile</a>
-    </p>
-    `,
-```
-or:
-
-```js
-// gitprofile.config.js
-
-// This is a plain text footer
-const config = {
-  [...]
-  footer: 'Copyright 2002, John Doe'
-```
-
-
 ## 💖 Support
 
 <p>You can show your support by starring this project. ★</p>
diff --git a/gitprofile.config.js b/gitprofile.config.js
index 895edc0..53d3bbe 100644
--- a/gitprofile.config.js
+++ b/gitprofile.config.js
@@ -83,10 +83,15 @@ const config = {
     },
   ],
 
-  // Optional custom footer. See README file, section "custom-footer", for details
-  /*
-  footer: '[...]',
-  */
+  // Optional custom footer
+  footer: `<p class="font-mono text-sm">
+    Made with <a
+      class="text-primary"
+      href="https://github.com/arifszn/gitprofile"
+      target="_blank"
+      rel="noreferrer"
+    >GitProfile</a> and ❤️
+    </p>`,
   // To hide the `My Projects` section, keep it empty.
   externalProjects: [
     {
diff --git a/src/components/footer/index.jsx b/src/components/footer/index.jsx
index 292d0c1..fa4c62c 100644
--- a/src/components/footer/index.jsx
+++ b/src/components/footer/index.jsx
@@ -2,33 +2,16 @@ import PropTypes from 'prop-types';
 
 import { skeleton } from '../../helpers/utils';
 
-const DefaultFooter = () => {
-  return (
-    <a
-      href="https://github.com/arifszn/gitprofile"
-      target="_blank"
-      rel="noreferrer"
-    >
-      <div>
-        <p className="font-mono text-sm">
-          Made with <span className="text-primary">GitProfile</span> and ❤️
-        </p>
-      </div>
-    </a>
-  );
-};
-
 const Footer = ({ content, loading }) => {
-  let footerContent = null;
-  if (content) {
-    footerContent = <div dangerouslySetInnerHTML={{ __html: content }} />;
-  } else {
-    footerContent = <DefaultFooter />;
-  }
+  if (!content) return null;
 
   return (
     <div className="card-body">
-      {loading ? skeleton({ width: 'w-52', height: 'h-6' }) : footerContent}
+      {loading ? (
+        skeleton({ width: 'w-52', height: 'h-6' })
+      ) : (
+        <div dangerouslySetInnerHTML={{ __html: content }} />
+      )}
     </div>
   );
 };