From e6f678eacd2c34d0ae627159f7286323ab7ade5e Mon Sep 17 00:00:00 2001 From: Yang Wei Hao Date: Sun, 9 Oct 2022 18:12:30 +0800 Subject: [PATCH 1/2] Add loading indicator for Download Resume button --- src/components/avatar-card/index.jsx | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/src/components/avatar-card/index.jsx b/src/components/avatar-card/index.jsx index 525c8dd..19c8e23 100644 --- a/src/components/avatar-card/index.jsx +++ b/src/components/avatar-card/index.jsx @@ -55,17 +55,22 @@ const AvatarCard = ({ profile, loading, avatarRing, resume }) => { : profile.bio} - {resume?.fileUrl && ( - - Download Resume - - )} + {resume?.fileUrl && + (loading ? ( +
+ {skeleton({ width: 'w-48', height: 'h-5' })} +
+ ) : ( + + Download Resume + + ))} ); From b42202d9234811eb0e53fac46d48aba0bb508eb5 Mon Sep 17 00:00:00 2001 From: Yang Wei Hao Date: Tue, 11 Oct 2022 18:31:26 +0800 Subject: [PATCH 2/2] Update css based on suggestion Co-authored-by: Ariful Alam --- src/components/avatar-card/index.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/avatar-card/index.jsx b/src/components/avatar-card/index.jsx index 19c8e23..8bab6f4 100644 --- a/src/components/avatar-card/index.jsx +++ b/src/components/avatar-card/index.jsx @@ -57,8 +57,8 @@ const AvatarCard = ({ profile, loading, avatarRing, resume }) => { {resume?.fileUrl && (loading ? ( -
- {skeleton({ width: 'w-48', height: 'h-5' })} +
+ {skeleton({ width: 'w-40', height: 'h-10' })}
) : (