All checks were successful
CI / skip-ci-check (pull_request) Successful in 1m23s
CI / lint-and-type-check (pull_request) Successful in 1m47s
CI / test (pull_request) Successful in 1m51s
CI / build (pull_request) Successful in 1m52s
CI / secret-scanning (pull_request) Successful in 1m25s
CI / dependency-scan (pull_request) Successful in 1m28s
CI / sast-scan (pull_request) Successful in 2m32s
CI / workflow-summary (pull_request) Successful in 1m22s
This document lists code and features that were added during development/debugging that might be candidates for cleanup or removal in the future. ## Debug/Development Code ### 1. Verbose Logging in Production **Location:** Multiple files **Status:** Consider reducing in production - `lib/auth.ts` - Session callback logging (lines 78-103, 105-113) - Logs full session details on every session creation - Could be reduced to warnings only or removed in production - `app/photos/page.tsx` - Page render logging (lines 12-33) - Logs auth() calls and session details - Useful for debugging but verbose for production - `app/api/debug/session/route.ts` - Entire debug endpoint - Created for debugging session issues - Consider removing or protecting with admin-only access - Or move to development-only route ### 2. Activity Logging **Location:** `lib/activity-log.ts`, `proxy.ts`, API routes **Status:** Keep but consider optimization - Activity logging is useful for monitoring - Consider: - Moving to structured logging (JSON format) - Adding log rotation/retention policies - Option to disable in production if not needed - Rate limiting logs to prevent spam ### 3. Upload Verification Logging **Location:** `app/api/photos/upload/route.ts` **Status:** Keep but reduce verbosity - Lines 89-91: Directory creation/existence logging - Lines 101: File save verification logging - Useful for debugging but could be reduced to errors only ### 4. Middleware Debug Logging **Location:** `proxy.ts` **Status:** Keep but consider reducing - Lines 22-37: Activity logging for all requests - Useful for monitoring but generates many logs - Consider: log only important events or add log level filtering ## Unused/Redundant Code ### 5. Legacy Upload Route **Location:** `app/api/photos/route.ts` **Status:** Consider deprecating - Legacy URL-based upload endpoint - New uploads use `/api/photos/upload` - Consider: - Marking as deprecated - Removing if not used - Or consolidating with upload route ### 6. Multiple Upload Routes **Location:** `app/api/photos/upload/route.ts` and `app/api/photos/upload-multiple/route.ts` **Status:** Keep but document usage - Two separate upload endpoints - Consider if both are needed or can be consolidated ### 7. Proxy.ts Cookie Name Variable **Location:** `proxy.ts` line 15 **Status:** Minor cleanup - `cookieName` variable defined but could use constant - Consider moving to shared constant or env var ## Configuration Cleanup ### 8. Next.js Config **Location:** `next.config.ts` **Status:** Review - Image optimization settings (line 19: `unoptimized: false`) - Consider if all remote patterns are needed - Review Turbopack configuration if not using ## Documentation Cleanup ### 10. ARCHITECTURE.md References **Location:** `ARCHITECTURE.md` line 156 **Status:** Update - Still references `middleware.ts` in some places - Should reference `proxy.ts` instead - Update all middleware references ## Testing/Debugging Utilities ### 11. Watch Activity Script **Location:** `watch-activity.sh` (if created) **Status:** Keep or document - Useful utility for monitoring - Consider adding to README or removing if not needed ## Recommendations ### High Priority (Consider Removing) 1. `app/api/debug/session/route.ts` - Debug endpoint (protect or remove) 2. Verbose logging in `app/photos/page.tsx` - Reduce to errors only 3. Update ARCHITECTURE.md middleware references ### Medium Priority (Optimize) 1. Activity logging - Add log levels or filtering 2. Upload logging - Reduce verbosity 3. Session callback logging - Reduce in production ### Low Priority (Keep) 1. Activity logging utility - Useful for monitoring 2. Multiple upload routes - Document usage 3. Watch activity script - Useful utility ## Notes - **Consider** adding environment-based log levels (DEBUG, INFO, WARN, ERROR) - **Consider** moving debug endpoints behind admin authentication - **Consider** adding log rotation/retention for production --- Do all these in stages. create new tests and test and docuemtn as u go. add DEBUG, INFO, WARN, ERROR flags and only show when asked for. create new branch.
92 lines
3.3 KiB
TypeScript
92 lines
3.3 KiB
TypeScript
import { auth } from "@/lib/auth"
|
|
import { redirect } from "next/navigation"
|
|
import { prisma } from "@/lib/prisma"
|
|
import Link from "next/link"
|
|
import PhotoThumbnail from "@/components/PhotoThumbnail"
|
|
import DeletePhotoButton from "@/components/DeletePhotoButton"
|
|
import { logger } from "@/lib/logger"
|
|
|
|
// Enable caching for this page
|
|
export const revalidate = 60 // Revalidate every 60 seconds
|
|
|
|
export default async function PhotosPage() {
|
|
// DEBUG level: only logs in development or when LOG_LEVEL=DEBUG
|
|
logger.debug("PhotosPage: Starting, calling auth()")
|
|
const session = await auth()
|
|
|
|
if (!session) {
|
|
logger.debug("PhotosPage: No session, redirecting to login")
|
|
redirect("/login")
|
|
}
|
|
|
|
if (!session.user) {
|
|
// WARN level: session exists but no user is a warning condition
|
|
logger.warn("PhotosPage: Session exists but no user, redirecting to login", {
|
|
hasSession: !!session,
|
|
sessionKeys: session ? Object.keys(session) : [],
|
|
})
|
|
redirect("/login")
|
|
}
|
|
|
|
logger.debug("PhotosPage: Session valid, rendering page", {
|
|
userId: session.user.id,
|
|
userEmail: session.user.email,
|
|
})
|
|
|
|
// Limit to 50 photos per page for performance
|
|
const photos = await prisma.photo.findMany({
|
|
take: 50,
|
|
orderBy: { createdAt: "desc" },
|
|
include: {
|
|
uploader: {
|
|
select: {
|
|
name: true,
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
return (
|
|
<div className="max-w-7xl mx-auto px-4 py-8">
|
|
<h1 className="text-3xl font-bold text-gray-900 mb-6">All Photos</h1>
|
|
|
|
{photos.length === 0 ? (
|
|
<div className="bg-white rounded-lg shadow-md p-8 text-center">
|
|
<p className="text-gray-500">No photos yet. Be the first to upload one!</p>
|
|
</div>
|
|
) : (
|
|
<div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-3 xl:grid-cols-4 gap-6">
|
|
{photos.map((photo: { id: string; url: string; answerName: string; points: number; createdAt: Date; uploader: { name: string } }) => (
|
|
<div
|
|
key={photo.id}
|
|
className="bg-white rounded-lg shadow-md overflow-hidden hover:shadow-lg transition relative group"
|
|
>
|
|
<Link href={`/photos/${photo.id}`}>
|
|
<div className="aspect-square bg-gray-200 relative">
|
|
<PhotoThumbnail src={photo.url} alt="Photo" />
|
|
</div>
|
|
<div className="p-4">
|
|
<div className="flex items-center justify-between mb-1">
|
|
<p className="text-sm text-gray-500">Uploaded by {photo.uploader.name}</p>
|
|
<span className="inline-flex items-center px-2 py-0.5 rounded text-xs font-medium bg-purple-100 text-purple-800">
|
|
{photo.points} {photo.points === 1 ? "pt" : "pts"}
|
|
</span>
|
|
</div>
|
|
<p className="text-xs text-gray-400 mt-1">
|
|
{new Date(photo.createdAt).toLocaleDateString()}
|
|
</p>
|
|
</div>
|
|
</Link>
|
|
{session.user.role === "ADMIN" && (
|
|
<div className="absolute top-2 right-2 opacity-0 group-hover:opacity-100 transition-opacity">
|
|
<DeletePhotoButton photoId={photo.id} />
|
|
</div>
|
|
)}
|
|
</div>
|
|
))}
|
|
</div>
|
|
)}
|
|
</div>
|
|
)
|
|
}
|