All checks were successful
CI / skip-ci-check (pull_request) Successful in 1m23s
CI / lint-and-type-check (pull_request) Successful in 1m47s
CI / test (pull_request) Successful in 1m51s
CI / build (pull_request) Successful in 1m52s
CI / secret-scanning (pull_request) Successful in 1m25s
CI / dependency-scan (pull_request) Successful in 1m28s
CI / sast-scan (pull_request) Successful in 2m32s
CI / workflow-summary (pull_request) Successful in 1m22s
This document lists code and features that were added during development/debugging that might be candidates for cleanup or removal in the future. ## Debug/Development Code ### 1. Verbose Logging in Production **Location:** Multiple files **Status:** Consider reducing in production - `lib/auth.ts` - Session callback logging (lines 78-103, 105-113) - Logs full session details on every session creation - Could be reduced to warnings only or removed in production - `app/photos/page.tsx` - Page render logging (lines 12-33) - Logs auth() calls and session details - Useful for debugging but verbose for production - `app/api/debug/session/route.ts` - Entire debug endpoint - Created for debugging session issues - Consider removing or protecting with admin-only access - Or move to development-only route ### 2. Activity Logging **Location:** `lib/activity-log.ts`, `proxy.ts`, API routes **Status:** Keep but consider optimization - Activity logging is useful for monitoring - Consider: - Moving to structured logging (JSON format) - Adding log rotation/retention policies - Option to disable in production if not needed - Rate limiting logs to prevent spam ### 3. Upload Verification Logging **Location:** `app/api/photos/upload/route.ts` **Status:** Keep but reduce verbosity - Lines 89-91: Directory creation/existence logging - Lines 101: File save verification logging - Useful for debugging but could be reduced to errors only ### 4. Middleware Debug Logging **Location:** `proxy.ts` **Status:** Keep but consider reducing - Lines 22-37: Activity logging for all requests - Useful for monitoring but generates many logs - Consider: log only important events or add log level filtering ## Unused/Redundant Code ### 5. Legacy Upload Route **Location:** `app/api/photos/route.ts` **Status:** Consider deprecating - Legacy URL-based upload endpoint - New uploads use `/api/photos/upload` - Consider: - Marking as deprecated - Removing if not used - Or consolidating with upload route ### 6. Multiple Upload Routes **Location:** `app/api/photos/upload/route.ts` and `app/api/photos/upload-multiple/route.ts` **Status:** Keep but document usage - Two separate upload endpoints - Consider if both are needed or can be consolidated ### 7. Proxy.ts Cookie Name Variable **Location:** `proxy.ts` line 15 **Status:** Minor cleanup - `cookieName` variable defined but could use constant - Consider moving to shared constant or env var ## Configuration Cleanup ### 8. Next.js Config **Location:** `next.config.ts` **Status:** Review - Image optimization settings (line 19: `unoptimized: false`) - Consider if all remote patterns are needed - Review Turbopack configuration if not using ## Documentation Cleanup ### 10. ARCHITECTURE.md References **Location:** `ARCHITECTURE.md` line 156 **Status:** Update - Still references `middleware.ts` in some places - Should reference `proxy.ts` instead - Update all middleware references ## Testing/Debugging Utilities ### 11. Watch Activity Script **Location:** `watch-activity.sh` (if created) **Status:** Keep or document - Useful utility for monitoring - Consider adding to README or removing if not needed ## Recommendations ### High Priority (Consider Removing) 1. `app/api/debug/session/route.ts` - Debug endpoint (protect or remove) 2. Verbose logging in `app/photos/page.tsx` - Reduce to errors only 3. Update ARCHITECTURE.md middleware references ### Medium Priority (Optimize) 1. Activity logging - Add log levels or filtering 2. Upload logging - Reduce verbosity 3. Session callback logging - Reduce in production ### Low Priority (Keep) 1. Activity logging utility - Useful for monitoring 2. Multiple upload routes - Document usage 3. Watch activity script - Useful utility ## Notes - **Consider** adding environment-based log levels (DEBUG, INFO, WARN, ERROR) - **Consider** moving debug endpoints behind admin authentication - **Consider** adding log rotation/retention for production --- Do all these in stages. create new tests and test and docuemtn as u go. add DEBUG, INFO, WARN, ERROR flags and only show when asked for. create new branch.
164 lines
4.6 KiB
TypeScript
164 lines
4.6 KiB
TypeScript
import { NextRequest, NextResponse } from "next/server"
|
|
import { auth } from "@/lib/auth"
|
|
import { prisma } from "@/lib/prisma"
|
|
import { normalizeString } from "@/lib/utils"
|
|
import { logActivity } from "@/lib/activity-log"
|
|
import { logger } from "@/lib/logger"
|
|
|
|
export async function POST(
|
|
req: NextRequest,
|
|
{ params }: { params: Promise<{ photoId: string }> }
|
|
) {
|
|
try {
|
|
const session = await auth()
|
|
|
|
if (!session) {
|
|
return NextResponse.json({ error: "Unauthorized" }, { status: 401 })
|
|
}
|
|
|
|
const { photoId } = await params
|
|
const { guessText } = await req.json()
|
|
|
|
if (!guessText || !guessText.trim()) {
|
|
return NextResponse.json(
|
|
{ error: "Guess text is required" },
|
|
{ status: 400 }
|
|
)
|
|
}
|
|
|
|
const photo = await prisma.photo.findUnique({
|
|
where: { id: photoId },
|
|
})
|
|
|
|
if (!photo) {
|
|
return NextResponse.json({ error: "Photo not found" }, { status: 404 })
|
|
}
|
|
|
|
// Prevent users from guessing their own photos
|
|
if (photo.uploaderId === session.user.id) {
|
|
return NextResponse.json(
|
|
{ error: "You cannot guess on your own photos" },
|
|
{ status: 403 }
|
|
)
|
|
}
|
|
|
|
// Check if user already has a correct guess
|
|
const existingCorrectGuess = await prisma.guess.findFirst({
|
|
where: {
|
|
userId: session.user.id,
|
|
photoId: photoId,
|
|
correct: true,
|
|
},
|
|
})
|
|
|
|
if (existingCorrectGuess) {
|
|
return NextResponse.json(
|
|
{ error: "You already guessed this correctly" },
|
|
{ status: 400 }
|
|
)
|
|
}
|
|
|
|
// Check max attempts limit
|
|
const photoWithMaxAttempts = photo as typeof photo & { maxAttempts: number | null }
|
|
if (photoWithMaxAttempts.maxAttempts !== null && photoWithMaxAttempts.maxAttempts > 0) {
|
|
const userGuessCount = await prisma.guess.count({
|
|
where: {
|
|
userId: session.user.id,
|
|
photoId: photoId,
|
|
},
|
|
})
|
|
|
|
if (userGuessCount >= photoWithMaxAttempts.maxAttempts) {
|
|
return NextResponse.json(
|
|
{ error: `You have reached the maximum number of attempts (${photoWithMaxAttempts.maxAttempts}) for this photo` },
|
|
{ status: 400 }
|
|
)
|
|
}
|
|
}
|
|
|
|
// Check if guess is correct (case-insensitive, trimmed)
|
|
const normalizedGuess = normalizeString(guessText)
|
|
const normalizedAnswer = normalizeString(photo.answerName)
|
|
const isCorrect = normalizedGuess === normalizedAnswer
|
|
|
|
// Create the guess
|
|
const guess = await prisma.guess.create({
|
|
data: {
|
|
userId: session.user.id,
|
|
photoId: photoId,
|
|
guessText: guessText.trim(),
|
|
correct: isCorrect,
|
|
},
|
|
})
|
|
|
|
// Update user points based on guess result
|
|
let pointsChange = 0
|
|
const photoWithPenalty = photo as typeof photo & { penaltyEnabled: boolean; penaltyPoints: number }
|
|
|
|
if (isCorrect) {
|
|
// Award points for correct answer
|
|
pointsChange = photo.points
|
|
await prisma.user.update({
|
|
where: { id: session.user.id },
|
|
data: {
|
|
points: {
|
|
increment: photo.points, // Award points based on photo difficulty
|
|
},
|
|
},
|
|
})
|
|
} else if (photoWithPenalty.penaltyEnabled && photoWithPenalty.penaltyPoints > 0) {
|
|
// Deduct points for wrong answer if penalty is enabled
|
|
// First, get current user points to prevent going below 0
|
|
const currentUser = await prisma.user.findUnique({
|
|
where: { id: session.user.id },
|
|
select: { points: true },
|
|
})
|
|
|
|
if (currentUser) {
|
|
const currentPoints = currentUser.points
|
|
const penaltyAmount = photoWithPenalty.penaltyPoints
|
|
const newPoints = Math.max(0, currentPoints - penaltyAmount)
|
|
const actualDeduction = currentPoints - newPoints
|
|
|
|
pointsChange = -actualDeduction
|
|
|
|
await prisma.user.update({
|
|
where: { id: session.user.id },
|
|
data: {
|
|
points: newPoints,
|
|
},
|
|
})
|
|
}
|
|
}
|
|
|
|
// Log guess activity
|
|
logActivity(
|
|
"GUESS_SUBMIT",
|
|
`/api/photos/${photoId}/guess`,
|
|
"POST",
|
|
session.user,
|
|
{
|
|
photoId,
|
|
guessText: guess.guessText.substring(0, 50), // Truncate for privacy
|
|
correct: isCorrect,
|
|
pointsChange
|
|
},
|
|
req
|
|
)
|
|
|
|
return NextResponse.json({
|
|
guess,
|
|
correct: isCorrect,
|
|
pointsChange
|
|
})
|
|
} catch (error) {
|
|
logger.error("Error submitting guess", {
|
|
error: error instanceof Error ? error : new Error(String(error)),
|
|
})
|
|
return NextResponse.json(
|
|
{ error: "Internal server error" },
|
|
{ status: 500 }
|
|
)
|
|
}
|
|
}
|