All checks were successful
CI / skip-ci-check (pull_request) Successful in 1m23s
CI / lint-and-type-check (pull_request) Successful in 1m47s
CI / test (pull_request) Successful in 1m51s
CI / build (pull_request) Successful in 1m52s
CI / secret-scanning (pull_request) Successful in 1m25s
CI / dependency-scan (pull_request) Successful in 1m28s
CI / sast-scan (pull_request) Successful in 2m32s
CI / workflow-summary (pull_request) Successful in 1m22s
This document lists code and features that were added during development/debugging that might be candidates for cleanup or removal in the future. ## Debug/Development Code ### 1. Verbose Logging in Production **Location:** Multiple files **Status:** Consider reducing in production - `lib/auth.ts` - Session callback logging (lines 78-103, 105-113) - Logs full session details on every session creation - Could be reduced to warnings only or removed in production - `app/photos/page.tsx` - Page render logging (lines 12-33) - Logs auth() calls and session details - Useful for debugging but verbose for production - `app/api/debug/session/route.ts` - Entire debug endpoint - Created for debugging session issues - Consider removing or protecting with admin-only access - Or move to development-only route ### 2. Activity Logging **Location:** `lib/activity-log.ts`, `proxy.ts`, API routes **Status:** Keep but consider optimization - Activity logging is useful for monitoring - Consider: - Moving to structured logging (JSON format) - Adding log rotation/retention policies - Option to disable in production if not needed - Rate limiting logs to prevent spam ### 3. Upload Verification Logging **Location:** `app/api/photos/upload/route.ts` **Status:** Keep but reduce verbosity - Lines 89-91: Directory creation/existence logging - Lines 101: File save verification logging - Useful for debugging but could be reduced to errors only ### 4. Middleware Debug Logging **Location:** `proxy.ts` **Status:** Keep but consider reducing - Lines 22-37: Activity logging for all requests - Useful for monitoring but generates many logs - Consider: log only important events or add log level filtering ## Unused/Redundant Code ### 5. Legacy Upload Route **Location:** `app/api/photos/route.ts` **Status:** Consider deprecating - Legacy URL-based upload endpoint - New uploads use `/api/photos/upload` - Consider: - Marking as deprecated - Removing if not used - Or consolidating with upload route ### 6. Multiple Upload Routes **Location:** `app/api/photos/upload/route.ts` and `app/api/photos/upload-multiple/route.ts` **Status:** Keep but document usage - Two separate upload endpoints - Consider if both are needed or can be consolidated ### 7. Proxy.ts Cookie Name Variable **Location:** `proxy.ts` line 15 **Status:** Minor cleanup - `cookieName` variable defined but could use constant - Consider moving to shared constant or env var ## Configuration Cleanup ### 8. Next.js Config **Location:** `next.config.ts` **Status:** Review - Image optimization settings (line 19: `unoptimized: false`) - Consider if all remote patterns are needed - Review Turbopack configuration if not using ## Documentation Cleanup ### 10. ARCHITECTURE.md References **Location:** `ARCHITECTURE.md` line 156 **Status:** Update - Still references `middleware.ts` in some places - Should reference `proxy.ts` instead - Update all middleware references ## Testing/Debugging Utilities ### 11. Watch Activity Script **Location:** `watch-activity.sh` (if created) **Status:** Keep or document - Useful utility for monitoring - Consider adding to README or removing if not needed ## Recommendations ### High Priority (Consider Removing) 1. `app/api/debug/session/route.ts` - Debug endpoint (protect or remove) 2. Verbose logging in `app/photos/page.tsx` - Reduce to errors only 3. Update ARCHITECTURE.md middleware references ### Medium Priority (Optimize) 1. Activity logging - Add log levels or filtering 2. Upload logging - Reduce verbosity 3. Session callback logging - Reduce in production ### Low Priority (Keep) 1. Activity logging utility - Useful for monitoring 2. Multiple upload routes - Document usage 3. Watch activity script - Useful utility ## Notes - **Consider** adding environment-based log levels (DEBUG, INFO, WARN, ERROR) - **Consider** moving debug endpoints behind admin authentication - **Consider** adding log rotation/retention for production --- Do all these in stages. create new tests and test and docuemtn as u go. add DEBUG, INFO, WARN, ERROR flags and only show when asked for. create new branch.
97 lines
3.5 KiB
TypeScript
97 lines
3.5 KiB
TypeScript
import { auth } from "@/lib/auth"
|
|
import { NextResponse } from "next/server"
|
|
import { cookies } from "next/headers"
|
|
import { SESSION_COOKIE_NAME } from "@/lib/constants"
|
|
import { logger } from "@/lib/logger"
|
|
|
|
/**
|
|
* Debug endpoint for session inspection
|
|
* ADMIN ONLY - Protected endpoint for debugging session issues
|
|
*
|
|
* This endpoint should only be accessible to administrators.
|
|
* Consider removing in production or restricting further.
|
|
*/
|
|
export async function GET(request: Request) {
|
|
try {
|
|
// Require admin authentication
|
|
const session = await auth()
|
|
|
|
if (!session || session.user.role !== "ADMIN") {
|
|
logger.warn("Unauthorized access attempt to debug endpoint", {
|
|
userId: session?.user?.id,
|
|
userRole: session?.user?.role,
|
|
path: "/api/debug/session",
|
|
})
|
|
return NextResponse.json({ error: "Unauthorized" }, { status: 401 })
|
|
}
|
|
const cookieHeader = request.headers.get("cookie") || ""
|
|
|
|
// Parse cookies from header first
|
|
const cookieMap: Record<string, string> = {}
|
|
cookieHeader.split(";").forEach(cookie => {
|
|
const [key, value] = cookie.trim().split("=")
|
|
if (key && value) {
|
|
cookieMap[key] = decodeURIComponent(value)
|
|
}
|
|
})
|
|
|
|
// Try to get session token from cookies
|
|
const sessionTokenFromHeader = cookieMap[SESSION_COOKIE_NAME] || "NOT FOUND"
|
|
|
|
// Try to call auth() again for debugging (we already have session above, but this is for testing)
|
|
let authError = null
|
|
try {
|
|
// Already called above, but keeping for backward compatibility in response
|
|
logger.debug("Debug endpoint: Session retrieved", {
|
|
hasSession: !!session,
|
|
userId: session?.user?.id,
|
|
userRole: session?.user?.role,
|
|
})
|
|
} catch (err) {
|
|
authError = err instanceof Error ? err.message : String(err)
|
|
logger.error("Debug endpoint: auth() error", {
|
|
error: err instanceof Error ? err : new Error(String(err)),
|
|
})
|
|
}
|
|
|
|
// Try to get cookie from Next.js cookie store
|
|
let sessionTokenFromStore = "NOT ACCESSIBLE"
|
|
try {
|
|
const cookieStore = await cookies()
|
|
sessionTokenFromStore = cookieStore.get(SESSION_COOKIE_NAME)?.value || "NOT FOUND"
|
|
} catch {
|
|
// Cookie store might not be accessible in all contexts
|
|
}
|
|
|
|
return NextResponse.json({
|
|
hasSession: !!session,
|
|
session: session ? {
|
|
user: session.user,
|
|
expires: session.expires,
|
|
} : null,
|
|
authError,
|
|
cookies: {
|
|
sessionTokenInHeader: sessionTokenFromHeader !== "NOT FOUND",
|
|
sessionTokenInStore: sessionTokenFromStore !== "NOT FOUND" && sessionTokenFromStore !== "NOT ACCESSIBLE",
|
|
sessionTokenPreview: sessionTokenFromHeader !== "NOT FOUND" ? `${sessionTokenFromHeader.substring(0, 30)}...` : "NOT FOUND",
|
|
allCookieKeys: Object.keys(cookieMap),
|
|
cookieHeaderLength: cookieHeader.length,
|
|
cookieHeaderPreview: cookieHeader.substring(0, 200),
|
|
},
|
|
env: {
|
|
hasSecret: !!process.env.NEXTAUTH_SECRET,
|
|
nextAuthUrl: process.env.NEXTAUTH_URL,
|
|
nodeEnv: process.env.NODE_ENV,
|
|
authTrustHost: process.env.AUTH_TRUST_HOST,
|
|
secretLength: process.env.NEXTAUTH_SECRET?.length || 0,
|
|
secretPreview: process.env.NEXTAUTH_SECRET ? `${process.env.NEXTAUTH_SECRET.substring(0, 10)}...` : "missing",
|
|
}
|
|
})
|
|
} catch (error) {
|
|
return NextResponse.json({
|
|
error: error instanceof Error ? error.message : "Unknown error",
|
|
stack: error instanceof Error ? error.stack : undefined
|
|
}, { status: 500 })
|
|
}
|
|
}
|