All checks were successful
CI / skip-ci-check (push) Successful in 1m25s
CI / lint-and-type-check (push) Successful in 1m50s
CI / test (push) Successful in 1m54s
CI / build (push) Successful in 1m54s
CI / secret-scanning (push) Successful in 1m26s
CI / dependency-scan (push) Successful in 1m31s
CI / sast-scan (push) Successful in 2m34s
CI / workflow-summary (push) Successful in 1m23s
# Fix authentication issues and improve developer experience ## Summary This MR fixes critical authentication issues that prevented login on localhost and improves the developer experience with consolidated rebuild scripts and a working help modal keyboard shortcut. ## Problems Fixed ### 1. Authentication Issues - **UntrustedHost Error**: NextAuth v5 was rejecting localhost requests with "UntrustedHost: Host must be trusted" error - **Cookie Prefix Errors**: Cookies were being set with `__Host-` and `__Secure-` prefixes on HTTP (localhost), causing browser rejection - **MissingCSRF Error**: CSRF token cookies were not being set correctly due to cookie configuration issues ### 2. Help Modal Keyboard Shortcut - **Shift+? not working**: The help modal keyboard shortcut was not detecting the question mark key correctly ### 3. Developer Experience - **Multiple rebuild scripts**: Had several overlapping rebuild scripts that were confusing - **Unused code**: Removed unused `useSecureCookies` variable and misleading comments ## Changes Made ### Authentication Fixes (`lib/auth.ts`) - Set `trustHost: true` to fix UntrustedHost error (required for NextAuth v5) - Added explicit cookie configuration for HTTP (localhost) to prevent prefix errors: - Cookies use `secure: false` for HTTP - Cookie names without prefixes for HTTP - Let Auth.js defaults handle HTTPS (with prefixes and Secure flag) - Removed unused `useSecureCookies` variable - Simplified debug logging ### Help Modal Fix (`components/HelpModal.tsx`) - Fixed keyboard shortcut detection to properly handle Shift+? (Shift+/) - Updated help text to show correct shortcut (Shift+? instead of Ctrl+?) ### Developer Scripts - **Consolidated rebuild scripts**: Merged `CLEAN_REBUILD.sh`, `FIX_AND_RESTART.sh`, and `start-server.sh` into single `rebuild.sh` - **Added REBUILD.md**: Documentation for rebuild process - Removed redundant script files ### Code Cleanup - Removed unused `useSecureCookies` variable from `lib/auth.ts` - Removed misleading comment from `app/api/auth/[...nextauth]/route.ts` - Cleaned up verbose debug logging ## Technical Details ### Cookie Configuration The fix works by explicitly configuring cookies for HTTP environments: - **HTTP (localhost)**: Cookies without prefixes, `secure: false` - **HTTPS (production)**: Let Auth.js defaults handle (prefixes + Secure flag) This prevents NextAuth v5 from auto-detecting HTTPS from proxy headers and incorrectly adding cookie prefixes. ### Keyboard Shortcut The question mark key requires Shift+/ on most keyboards. The fix now properly detects: - `event.shiftKey && event.key === "/"` - `event.key === "?"` (fallback) - `event.code === "Slash" && event.shiftKey` (additional fallback) ## Testing - ✅ Login works on localhost (http://localhost:3000) - ✅ No cookie prefix errors in browser console - ✅ No UntrustedHost errors in server logs - ✅ Help modal opens/closes with Shift+? - ✅ Rebuild script works in both dev and prod modes ## Files Changed ### Modified - `lib/auth.ts` - Authentication configuration fixes - `components/HelpModal.tsx` - Keyboard shortcut fix - `app/api/auth/[...nextauth]/route.ts` - Removed misleading comment ### Added - `rebuild.sh` - Consolidated rebuild script - `REBUILD.md` - Rebuild documentation ## Migration Notes No database migrations or environment variable changes required. The fix works with existing configuration. ## Related Issues Fixes authentication issues preventing local development and testing. Reviewed-on: #5
100 lines
3.6 KiB
TypeScript
100 lines
3.6 KiB
TypeScript
import { auth } from "@/lib/auth"
|
|
import { NextResponse } from "next/server"
|
|
import { cookies } from "next/headers"
|
|
import { SESSION_COOKIE_NAME } from "@/lib/constants"
|
|
import { logger } from "@/lib/logger"
|
|
|
|
// Mark this route as dynamic to prevent build-time data collection
|
|
export const dynamic = "force-dynamic"
|
|
|
|
/**
|
|
* Debug endpoint for session inspection
|
|
* ADMIN ONLY - Protected endpoint for debugging session issues
|
|
*
|
|
* This endpoint should only be accessible to administrators.
|
|
* Consider removing in production or restricting further.
|
|
*/
|
|
export async function GET(request: Request) {
|
|
try {
|
|
// Require admin authentication
|
|
const session = await auth()
|
|
|
|
if (!session || session.user.role !== "ADMIN") {
|
|
logger.warn("Unauthorized access attempt to debug endpoint", {
|
|
userId: session?.user?.id,
|
|
userRole: session?.user?.role,
|
|
path: "/api/debug/session",
|
|
})
|
|
return NextResponse.json({ error: "Unauthorized" }, { status: 401 })
|
|
}
|
|
const cookieHeader = request.headers.get("cookie") || ""
|
|
|
|
// Parse cookies from header first
|
|
const cookieMap: Record<string, string> = {}
|
|
cookieHeader.split(";").forEach(cookie => {
|
|
const [key, value] = cookie.trim().split("=")
|
|
if (key && value) {
|
|
cookieMap[key] = decodeURIComponent(value)
|
|
}
|
|
})
|
|
|
|
// Try to get session token from cookies
|
|
const sessionTokenFromHeader = cookieMap[SESSION_COOKIE_NAME] || "NOT FOUND"
|
|
|
|
// Try to call auth() again for debugging (we already have session above, but this is for testing)
|
|
let authError = null
|
|
try {
|
|
// Already called above, but keeping for backward compatibility in response
|
|
logger.debug("Debug endpoint: Session retrieved", {
|
|
hasSession: !!session,
|
|
userId: session?.user?.id,
|
|
userRole: session?.user?.role,
|
|
})
|
|
} catch (err) {
|
|
authError = err instanceof Error ? err.message : String(err)
|
|
logger.error("Debug endpoint: auth() error", {
|
|
error: err instanceof Error ? err : new Error(String(err)),
|
|
})
|
|
}
|
|
|
|
// Try to get cookie from Next.js cookie store
|
|
let sessionTokenFromStore = "NOT ACCESSIBLE"
|
|
try {
|
|
const cookieStore = await cookies()
|
|
sessionTokenFromStore = cookieStore.get(SESSION_COOKIE_NAME)?.value || "NOT FOUND"
|
|
} catch {
|
|
// Cookie store might not be accessible in all contexts
|
|
}
|
|
|
|
return NextResponse.json({
|
|
hasSession: !!session,
|
|
session: session ? {
|
|
user: session.user,
|
|
expires: session.expires,
|
|
} : null,
|
|
authError,
|
|
cookies: {
|
|
sessionTokenInHeader: sessionTokenFromHeader !== "NOT FOUND",
|
|
sessionTokenInStore: sessionTokenFromStore !== "NOT FOUND" && sessionTokenFromStore !== "NOT ACCESSIBLE",
|
|
sessionTokenPreview: sessionTokenFromHeader !== "NOT FOUND" ? `${sessionTokenFromHeader.substring(0, 30)}...` : "NOT FOUND",
|
|
allCookieKeys: Object.keys(cookieMap),
|
|
cookieHeaderLength: cookieHeader.length,
|
|
cookieHeaderPreview: cookieHeader.substring(0, 200),
|
|
},
|
|
env: {
|
|
hasSecret: !!process.env.NEXTAUTH_SECRET,
|
|
nextAuthUrl: process.env.NEXTAUTH_URL,
|
|
nodeEnv: process.env.NODE_ENV,
|
|
authTrustHost: process.env.AUTH_TRUST_HOST,
|
|
secretLength: process.env.NEXTAUTH_SECRET?.length || 0,
|
|
secretPreview: process.env.NEXTAUTH_SECRET ? `${process.env.NEXTAUTH_SECRET.substring(0, 10)}...` : "missing",
|
|
}
|
|
})
|
|
} catch (error) {
|
|
return NextResponse.json({
|
|
error: error instanceof Error ? error.message : "Unknown error",
|
|
stack: error instanceof Error ? error.stack : undefined
|
|
}, { status: 500 })
|
|
}
|
|
}
|