All checks were successful
CI / skip-ci-check (push) Successful in 1m21s
CI / lint-and-type-check (push) Successful in 1m45s
CI / test (push) Successful in 1m49s
CI / build (push) Successful in 1m50s
CI / secret-scanning (push) Successful in 1m22s
CI / dependency-scan (push) Successful in 1m27s
CI / sast-scan (push) Successful in 2m27s
CI / workflow-summary (push) Successful in 1m19s
# Photo Management and Game Features ## Summary This PR adds comprehensive photo management features, duplicate detection, attempt limits, penalty system improvements, and admin photo deletion capabilities to the MirrorMatch application. ## Features Added ### 1. Duplicate Photo Detection - **File-based duplicates**: Calculates SHA256 hash of uploaded files to detect duplicate content - **URL-based duplicates**: Checks for duplicate photo URLs - Prevents users from uploading the same photo multiple times - Returns HTTP 409 (Conflict) with clear error messages ### 2. Maximum Attempts Per Photo - Uploaders can set a maximum number of guesses allowed per user for each photo - Default: unlimited (null or 0) - UI displays remaining attempts counter - API enforces attempt limits before allowing guesses - Shows warning message when max attempts reached ### 3. Penalty System Improvements - **Simplified UI**: Removed checkbox - penalty automatically enabled when penalty points > 0 - **Score protection**: Scores cannot go below 0, even with large penalties - If penalty would result in negative score, only deducts available points and sets to 0 ### 4. Admin Photo Deletion - Admins can delete photos from: - Photos list page (hover to reveal delete icon) - Individual photo detail page (delete button in header) - Deletes associated guesses automatically - Deletes local uploaded files from filesystem - Confirmation dialog before deletion - Proper error handling and user feedback ### 5. Navigation Improvements - Logout button always visible in side menu (hamburger menu) - Improved side menu layout with fixed footer for logout button - Better mobile responsiveness ### 6. Self-Guess Prevention - Users cannot guess on their own uploaded photos - Shows informative message with answer for photo owners ## Technical Changes ### Database Schema - Added `fileHash` field (String?) to Photo model for duplicate detection - Added `maxAttempts` field (Int?) to Photo model for attempt limits - Added indexes on `url` and `fileHash` for performance ### API Routes - `POST /api/photos/upload-multiple`: Enhanced with duplicate checking and maxAttempts - `POST /api/photos/[photoId]/guess`: Added maxAttempts enforcement and score floor protection - `DELETE /api/photos/[photoId]`: New route for admin photo deletion ### Components - `DeletePhotoButton`: New reusable component for photo deletion - Updated upload form to remove penalty checkbox - Enhanced photo display pages with attempt counters and admin controls ## Database Migrations - Run `npm run db:push` to apply schema changes - Run `npm run db:generate` to regenerate Prisma client ## Testing - Test duplicate detection with same file and different filenames - Test duplicate detection with same URL - Test max attempts enforcement - Test penalty system with various point values - Test score floor (cannot go below 0) - Test admin photo deletion - Test self-guess prevention ## Breaking Changes None - all changes are backward compatible. Existing photos will have `null` for `maxAttempts` (unlimited) and `fileHash` (for URL uploads). Reviewed-on: #1
226 lines
6.7 KiB
TypeScript
226 lines
6.7 KiB
TypeScript
import { NextRequest, NextResponse } from "next/server"
|
|
import { auth } from "@/lib/auth"
|
|
import { prisma } from "@/lib/prisma"
|
|
import { sendNewPhotoEmail } from "@/lib/email"
|
|
import { writeFile } from "fs/promises"
|
|
import { join } from "path"
|
|
import { existsSync, mkdirSync } from "fs"
|
|
import { createHash } from "crypto"
|
|
|
|
export async function POST(req: NextRequest) {
|
|
try {
|
|
const session = await auth()
|
|
|
|
if (!session) {
|
|
return NextResponse.json({ error: "Unauthorized" }, { status: 401 })
|
|
}
|
|
|
|
// Verify the user exists in the database
|
|
const user = await prisma.user.findUnique({
|
|
where: { id: session.user.id },
|
|
select: { id: true },
|
|
})
|
|
|
|
if (!user) {
|
|
return NextResponse.json(
|
|
{ error: "User not found. Please log out and log back in." },
|
|
{ status: 401 }
|
|
)
|
|
}
|
|
|
|
const formData = await req.formData()
|
|
const count = parseInt(formData.get("count") as string, 10)
|
|
|
|
if (!count || count < 1) {
|
|
return NextResponse.json(
|
|
{ error: "Invalid photo count" },
|
|
{ status: 400 }
|
|
)
|
|
}
|
|
|
|
const uploadsDir = join(process.cwd(), "public", "uploads")
|
|
if (!existsSync(uploadsDir)) {
|
|
mkdirSync(uploadsDir, { recursive: true })
|
|
}
|
|
|
|
type PhotoWithUploader = {
|
|
id: string
|
|
uploaderId: string
|
|
url: string
|
|
answerName: string
|
|
points: number
|
|
createdAt: Date
|
|
uploader: { name: string }
|
|
}
|
|
|
|
const createdPhotos: PhotoWithUploader[] = []
|
|
|
|
for (let i = 0; i < count; i++) {
|
|
const answerName = (formData.get(`photo_${i}_answerName`) as string)?.trim()
|
|
const pointsStr = (formData.get(`photo_${i}_points`) as string) || "1"
|
|
const pointsValue = Math.max(1, parseInt(pointsStr, 10))
|
|
const penaltyEnabled = formData.get(`photo_${i}_penaltyEnabled`) === "true"
|
|
const penaltyPointsStr = (formData.get(`photo_${i}_penaltyPoints`) as string) || "0"
|
|
const penaltyPointsValue = Math.max(0, parseInt(penaltyPointsStr, 10))
|
|
const maxAttemptsStr = (formData.get(`photo_${i}_maxAttempts`) as string)?.trim() || ""
|
|
const maxAttemptsValue = maxAttemptsStr && parseInt(maxAttemptsStr, 10) > 0
|
|
? parseInt(maxAttemptsStr, 10)
|
|
: null
|
|
|
|
if (!answerName) {
|
|
return NextResponse.json(
|
|
{ error: `Photo ${i + 1}: Answer name is required` },
|
|
{ status: 400 }
|
|
)
|
|
}
|
|
|
|
const file = formData.get(`photo_${i}_file`) as File | null
|
|
const url = (formData.get(`photo_${i}_url`) as string)?.trim() || null
|
|
|
|
if (!file && !url) {
|
|
return NextResponse.json(
|
|
{ error: `Photo ${i + 1}: File or URL is required` },
|
|
{ status: 400 }
|
|
)
|
|
}
|
|
|
|
let photoUrl: string
|
|
let fileHash: string | null = null
|
|
|
|
if (file) {
|
|
// Handle file upload
|
|
if (!file.type.startsWith("image/")) {
|
|
return NextResponse.json(
|
|
{ error: `Photo ${i + 1}: File must be an image` },
|
|
{ status: 400 }
|
|
)
|
|
}
|
|
|
|
if (file.size > 10 * 1024 * 1024) {
|
|
return NextResponse.json(
|
|
{ error: `Photo ${i + 1}: File size must be less than 10MB` },
|
|
{ status: 400 }
|
|
)
|
|
}
|
|
|
|
const bytes = await file.arrayBuffer()
|
|
const buffer = Buffer.from(bytes)
|
|
|
|
// Calculate SHA256 hash for duplicate detection
|
|
fileHash = createHash("sha256").update(buffer).digest("hex")
|
|
|
|
// Check for duplicate file
|
|
const existingPhoto = await prisma.photo.findFirst({
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
where: { fileHash } as any,
|
|
})
|
|
|
|
if (existingPhoto) {
|
|
return NextResponse.json(
|
|
{ error: `Photo ${i + 1}: This photo has already been uploaded (duplicate file detected)` },
|
|
{ status: 409 }
|
|
)
|
|
}
|
|
|
|
const timestamp = Date.now()
|
|
const randomStr = Math.random().toString(36).substring(2, 15)
|
|
// Sanitize extension - only allow alphanumeric characters
|
|
const rawExtension = file.name.split(".").pop() || "jpg"
|
|
const extension = rawExtension.replace(/[^a-zA-Z0-9]/g, "").toLowerCase() || "jpg"
|
|
const filename = `${timestamp}-${i}-${randomStr}.${extension}`
|
|
|
|
// Filename is generated server-side (timestamp + random), safe for path.join
|
|
const filepath = join(uploadsDir, filename)
|
|
await writeFile(filepath, buffer)
|
|
|
|
photoUrl = `/uploads/${filename}`
|
|
} else if (url) {
|
|
// Handle URL upload
|
|
photoUrl = url
|
|
|
|
// Check for duplicate URL
|
|
const existingPhoto = await prisma.photo.findFirst({
|
|
where: { url: photoUrl },
|
|
})
|
|
|
|
if (existingPhoto) {
|
|
return NextResponse.json(
|
|
{ error: `Photo ${i + 1}: This photo URL has already been uploaded (duplicate URL detected)` },
|
|
{ status: 409 }
|
|
)
|
|
}
|
|
} else {
|
|
return NextResponse.json(
|
|
{ error: `Photo ${i + 1}: File or URL is required` },
|
|
{ status: 400 }
|
|
)
|
|
}
|
|
|
|
// Create photo record
|
|
const photo = await prisma.photo.create({
|
|
data: {
|
|
uploaderId: session.user.id,
|
|
url: photoUrl,
|
|
fileHash,
|
|
answerName,
|
|
points: pointsValue,
|
|
penaltyEnabled: penaltyEnabled,
|
|
penaltyPoints: penaltyPointsValue,
|
|
maxAttempts: maxAttemptsValue,
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
} as any,
|
|
include: {
|
|
uploader: {
|
|
select: {
|
|
name: true,
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
createdPhotos.push(photo)
|
|
}
|
|
|
|
// Send emails to all other users for all photos
|
|
const allUsers = await prisma.user.findMany({
|
|
where: {
|
|
id: { not: session.user.id },
|
|
},
|
|
select: {
|
|
id: true,
|
|
email: true,
|
|
name: true,
|
|
},
|
|
})
|
|
|
|
// Send emails asynchronously for all photos
|
|
Promise.all(
|
|
allUsers.map((user: { id: string; email: string; name: string }) =>
|
|
Promise.all(
|
|
createdPhotos.map((photo: PhotoWithUploader) =>
|
|
sendNewPhotoEmail(
|
|
user.email,
|
|
user.name,
|
|
photo.id,
|
|
photo.uploader.name
|
|
).catch((err) => {
|
|
console.error("Failed to send email to:", user.email, "for photo:", photo.id, err)
|
|
})
|
|
)
|
|
)
|
|
)
|
|
)
|
|
|
|
return NextResponse.json(
|
|
{ photos: createdPhotos, count: createdPhotos.length },
|
|
{ status: 201 }
|
|
)
|
|
} catch (error) {
|
|
console.error("Error uploading photos:", error)
|
|
return NextResponse.json(
|
|
{ error: "Internal server error" },
|
|
{ status: 500 }
|
|
)
|
|
}
|
|
}
|