All checks were successful
CI / skip-ci-check (push) Successful in 1m25s
CI / lint-and-type-check (push) Successful in 1m50s
CI / test (push) Successful in 1m54s
CI / build (push) Successful in 1m54s
CI / secret-scanning (push) Successful in 1m26s
CI / dependency-scan (push) Successful in 1m31s
CI / sast-scan (push) Successful in 2m34s
CI / workflow-summary (push) Successful in 1m23s
# Fix authentication issues and improve developer experience ## Summary This MR fixes critical authentication issues that prevented login on localhost and improves the developer experience with consolidated rebuild scripts and a working help modal keyboard shortcut. ## Problems Fixed ### 1. Authentication Issues - **UntrustedHost Error**: NextAuth v5 was rejecting localhost requests with "UntrustedHost: Host must be trusted" error - **Cookie Prefix Errors**: Cookies were being set with `__Host-` and `__Secure-` prefixes on HTTP (localhost), causing browser rejection - **MissingCSRF Error**: CSRF token cookies were not being set correctly due to cookie configuration issues ### 2. Help Modal Keyboard Shortcut - **Shift+? not working**: The help modal keyboard shortcut was not detecting the question mark key correctly ### 3. Developer Experience - **Multiple rebuild scripts**: Had several overlapping rebuild scripts that were confusing - **Unused code**: Removed unused `useSecureCookies` variable and misleading comments ## Changes Made ### Authentication Fixes (`lib/auth.ts`) - Set `trustHost: true` to fix UntrustedHost error (required for NextAuth v5) - Added explicit cookie configuration for HTTP (localhost) to prevent prefix errors: - Cookies use `secure: false` for HTTP - Cookie names without prefixes for HTTP - Let Auth.js defaults handle HTTPS (with prefixes and Secure flag) - Removed unused `useSecureCookies` variable - Simplified debug logging ### Help Modal Fix (`components/HelpModal.tsx`) - Fixed keyboard shortcut detection to properly handle Shift+? (Shift+/) - Updated help text to show correct shortcut (Shift+? instead of Ctrl+?) ### Developer Scripts - **Consolidated rebuild scripts**: Merged `CLEAN_REBUILD.sh`, `FIX_AND_RESTART.sh`, and `start-server.sh` into single `rebuild.sh` - **Added REBUILD.md**: Documentation for rebuild process - Removed redundant script files ### Code Cleanup - Removed unused `useSecureCookies` variable from `lib/auth.ts` - Removed misleading comment from `app/api/auth/[...nextauth]/route.ts` - Cleaned up verbose debug logging ## Technical Details ### Cookie Configuration The fix works by explicitly configuring cookies for HTTP environments: - **HTTP (localhost)**: Cookies without prefixes, `secure: false` - **HTTPS (production)**: Let Auth.js defaults handle (prefixes + Secure flag) This prevents NextAuth v5 from auto-detecting HTTPS from proxy headers and incorrectly adding cookie prefixes. ### Keyboard Shortcut The question mark key requires Shift+/ on most keyboards. The fix now properly detects: - `event.shiftKey && event.key === "/"` - `event.key === "?"` (fallback) - `event.code === "Slash" && event.shiftKey` (additional fallback) ## Testing - ✅ Login works on localhost (http://localhost:3000) - ✅ No cookie prefix errors in browser console - ✅ No UntrustedHost errors in server logs - ✅ Help modal opens/closes with Shift+? - ✅ Rebuild script works in both dev and prod modes ## Files Changed ### Modified - `lib/auth.ts` - Authentication configuration fixes - `components/HelpModal.tsx` - Keyboard shortcut fix - `app/api/auth/[...nextauth]/route.ts` - Removed misleading comment ### Added - `rebuild.sh` - Consolidated rebuild script - `REBUILD.md` - Rebuild documentation ## Migration Notes No database migrations or environment variable changes required. The fix works with existing configuration. ## Related Issues Fixes authentication issues preventing local development and testing. Reviewed-on: #5
97 lines
2.7 KiB
Bash
Executable File
97 lines
2.7 KiB
Bash
Executable File
#!/bin/bash
|
|
# Complete clean rebuild and start script for MirrorMatch
|
|
# Usage: ./rebuild.sh [dev|prod]
|
|
# dev - Development mode (hot reload, foreground)
|
|
# prod - Production mode (optimized, background with logging)
|
|
|
|
set -e
|
|
|
|
# Get the directory where this script is located
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
cd "$SCRIPT_DIR" || {
|
|
echo "Error: Could not change to script directory: $SCRIPT_DIR"
|
|
exit 1
|
|
}
|
|
|
|
MODE=${1:-prod}
|
|
|
|
echo "========================================="
|
|
echo "MirrorMatch - Clean Rebuild & Start"
|
|
echo "Mode: ${MODE}"
|
|
echo "Working directory: $SCRIPT_DIR"
|
|
echo "========================================="
|
|
|
|
# Step 1: Kill everything
|
|
echo ""
|
|
echo "Step 1: Killing all processes..."
|
|
sudo fuser -k 3000/tcp 2>/dev/null || true
|
|
killall -9 node 2>/dev/null || true
|
|
pkill -f "next" 2>/dev/null || true
|
|
sleep 2
|
|
echo "✓ All processes killed"
|
|
|
|
# Step 2: Free ports
|
|
echo ""
|
|
echo "Step 2: Freeing ports..."
|
|
lsof -ti:3000 | xargs kill -9 2>/dev/null || true
|
|
lsof -ti:3003 | xargs kill -9 2>/dev/null || true
|
|
sleep 1
|
|
echo "✓ Ports freed"
|
|
|
|
# Step 3: Clean build artifacts
|
|
echo ""
|
|
echo "Step 3: Cleaning build artifacts..."
|
|
rm -rf .next node_modules/.cache .next/cache .next/dev/lock 2>/dev/null || true
|
|
echo "✓ Build artifacts cleaned"
|
|
|
|
# Step 4: Rebuild (only for production)
|
|
if [ "$MODE" = "prod" ]; then
|
|
echo ""
|
|
echo "Step 4: Rebuilding application..."
|
|
npm run build
|
|
echo "✓ Build complete"
|
|
fi
|
|
|
|
# Step 5: Start server
|
|
echo ""
|
|
echo "Step 5: Starting server..."
|
|
echo "========================================="
|
|
|
|
if [ "$MODE" = "dev" ]; then
|
|
echo "Development mode - logs will appear below:"
|
|
echo "Press Ctrl+C to stop"
|
|
echo "========================================="
|
|
echo ""
|
|
export NODE_ENV=development
|
|
unset AUTH_TRUST_HOST
|
|
npm run dev
|
|
else
|
|
LOG_FILE="${LOG_FILE:-/tmp/mirrormatch-server.log}"
|
|
echo "Production mode - server running in background"
|
|
echo "View logs: tail -f $LOG_FILE"
|
|
echo "========================================="
|
|
echo ""
|
|
export NODE_ENV=production
|
|
unset AUTH_TRUST_HOST
|
|
npm run start > "$LOG_FILE" 2>&1 &
|
|
SERVER_PID=$!
|
|
echo "Server PID: $SERVER_PID"
|
|
echo "Log file: $LOG_FILE"
|
|
echo ""
|
|
|
|
# Wait for server to start (check log file for "Ready" message or check HTTP)
|
|
echo "Waiting for server to start..."
|
|
for i in {1..30}; do
|
|
if curl -s -o /dev/null -w "%{http_code}" http://localhost:3000 2>/dev/null | grep -q "200\|307\|404"; then
|
|
echo "✓ Server is running on http://localhost:3000"
|
|
break
|
|
fi
|
|
if [ $i -eq 30 ]; then
|
|
echo "⚠ Server may still be starting. Check logs: tail -f $LOG_FILE"
|
|
echo " Or check if process is running: ps -p $SERVER_PID"
|
|
else
|
|
sleep 1
|
|
fi
|
|
done
|
|
fi
|