All checks were successful
CI / skip-ci-check (push) Successful in 1m25s
CI / lint-and-type-check (push) Successful in 1m50s
CI / test (push) Successful in 1m54s
CI / build (push) Successful in 1m54s
CI / secret-scanning (push) Successful in 1m26s
CI / dependency-scan (push) Successful in 1m31s
CI / sast-scan (push) Successful in 2m34s
CI / workflow-summary (push) Successful in 1m23s
# Fix authentication issues and improve developer experience ## Summary This MR fixes critical authentication issues that prevented login on localhost and improves the developer experience with consolidated rebuild scripts and a working help modal keyboard shortcut. ## Problems Fixed ### 1. Authentication Issues - **UntrustedHost Error**: NextAuth v5 was rejecting localhost requests with "UntrustedHost: Host must be trusted" error - **Cookie Prefix Errors**: Cookies were being set with `__Host-` and `__Secure-` prefixes on HTTP (localhost), causing browser rejection - **MissingCSRF Error**: CSRF token cookies were not being set correctly due to cookie configuration issues ### 2. Help Modal Keyboard Shortcut - **Shift+? not working**: The help modal keyboard shortcut was not detecting the question mark key correctly ### 3. Developer Experience - **Multiple rebuild scripts**: Had several overlapping rebuild scripts that were confusing - **Unused code**: Removed unused `useSecureCookies` variable and misleading comments ## Changes Made ### Authentication Fixes (`lib/auth.ts`) - Set `trustHost: true` to fix UntrustedHost error (required for NextAuth v5) - Added explicit cookie configuration for HTTP (localhost) to prevent prefix errors: - Cookies use `secure: false` for HTTP - Cookie names without prefixes for HTTP - Let Auth.js defaults handle HTTPS (with prefixes and Secure flag) - Removed unused `useSecureCookies` variable - Simplified debug logging ### Help Modal Fix (`components/HelpModal.tsx`) - Fixed keyboard shortcut detection to properly handle Shift+? (Shift+/) - Updated help text to show correct shortcut (Shift+? instead of Ctrl+?) ### Developer Scripts - **Consolidated rebuild scripts**: Merged `CLEAN_REBUILD.sh`, `FIX_AND_RESTART.sh`, and `start-server.sh` into single `rebuild.sh` - **Added REBUILD.md**: Documentation for rebuild process - Removed redundant script files ### Code Cleanup - Removed unused `useSecureCookies` variable from `lib/auth.ts` - Removed misleading comment from `app/api/auth/[...nextauth]/route.ts` - Cleaned up verbose debug logging ## Technical Details ### Cookie Configuration The fix works by explicitly configuring cookies for HTTP environments: - **HTTP (localhost)**: Cookies without prefixes, `secure: false` - **HTTPS (production)**: Let Auth.js defaults handle (prefixes + Secure flag) This prevents NextAuth v5 from auto-detecting HTTPS from proxy headers and incorrectly adding cookie prefixes. ### Keyboard Shortcut The question mark key requires Shift+/ on most keyboards. The fix now properly detects: - `event.shiftKey && event.key === "/"` - `event.key === "?"` (fallback) - `event.code === "Slash" && event.shiftKey` (additional fallback) ## Testing - ✅ Login works on localhost (http://localhost:3000) - ✅ No cookie prefix errors in browser console - ✅ No UntrustedHost errors in server logs - ✅ Help modal opens/closes with Shift+? - ✅ Rebuild script works in both dev and prod modes ## Files Changed ### Modified - `lib/auth.ts` - Authentication configuration fixes - `components/HelpModal.tsx` - Keyboard shortcut fix - `app/api/auth/[...nextauth]/route.ts` - Removed misleading comment ### Added - `rebuild.sh` - Consolidated rebuild script - `REBUILD.md` - Rebuild documentation ## Migration Notes No database migrations or environment variable changes required. The fix works with existing configuration. ## Related Issues Fixes authentication issues preventing local development and testing. Reviewed-on: #5
157 lines
4.0 KiB
TypeScript
157 lines
4.0 KiB
TypeScript
/**
|
|
* Structured logging utility with log levels and environment-based filtering
|
|
*
|
|
* Log levels (in order of severity):
|
|
* - DEBUG: Detailed information for debugging (only in development)
|
|
* - INFO: General informational messages
|
|
* - WARN: Warning messages for potentially harmful situations
|
|
* - ERROR: Error messages for error events
|
|
*
|
|
* Usage:
|
|
* import { logger } from '@/lib/logger'
|
|
* logger.debug('Debug message', { data })
|
|
* logger.info('Info message', { data })
|
|
* logger.warn('Warning message', { data })
|
|
* logger.error('Error message', { error })
|
|
*/
|
|
|
|
export enum LogLevel {
|
|
DEBUG = 0,
|
|
INFO = 1,
|
|
WARN = 2,
|
|
ERROR = 3,
|
|
NONE = 4, // Disable all logging
|
|
}
|
|
|
|
export interface LogContext {
|
|
[key: string]: unknown;
|
|
}
|
|
|
|
export interface Logger {
|
|
debug(message: string, context?: LogContext): void;
|
|
info(message: string, context?: LogContext): void;
|
|
warn(message: string, context?: LogContext): void;
|
|
error(message: string, context?: LogContext | Error): void;
|
|
isLevelEnabled(level: LogLevel): boolean;
|
|
}
|
|
|
|
/**
|
|
* Parse log level from environment variable or default based on NODE_ENV
|
|
*/
|
|
function getLogLevel(): LogLevel {
|
|
const envLogLevel = process.env.LOG_LEVEL?.toUpperCase();
|
|
|
|
// If explicitly set, use that
|
|
if (envLogLevel) {
|
|
switch (envLogLevel) {
|
|
case 'DEBUG':
|
|
return LogLevel.DEBUG;
|
|
case 'INFO':
|
|
return LogLevel.INFO;
|
|
case 'WARN':
|
|
return LogLevel.WARN;
|
|
case 'ERROR':
|
|
return LogLevel.ERROR;
|
|
case 'NONE':
|
|
return LogLevel.NONE;
|
|
default:
|
|
// Invalid value, fall through to default behavior
|
|
break;
|
|
}
|
|
}
|
|
|
|
// Default behavior: DEBUG in development, INFO in production
|
|
return process.env.NODE_ENV === 'production' ? LogLevel.INFO : LogLevel.DEBUG;
|
|
}
|
|
|
|
/**
|
|
* Format log entry as structured JSON or human-readable string
|
|
*/
|
|
function formatLog(
|
|
level: LogLevel,
|
|
message: string,
|
|
context?: LogContext | Error
|
|
): string {
|
|
const timestamp = new Date().toISOString();
|
|
const levelName = LogLevel[level];
|
|
|
|
// If structured logging is enabled, output JSON
|
|
if (process.env.LOG_FORMAT === 'json') {
|
|
const logEntry: Record<string, unknown> = {
|
|
timestamp,
|
|
level: levelName,
|
|
message,
|
|
};
|
|
|
|
if (context) {
|
|
if (context instanceof Error) {
|
|
logEntry.error = {
|
|
name: context.name,
|
|
message: context.message,
|
|
stack: context.stack,
|
|
};
|
|
} else {
|
|
Object.assign(logEntry, context);
|
|
}
|
|
}
|
|
|
|
return JSON.stringify(logEntry);
|
|
}
|
|
|
|
// Human-readable format
|
|
const contextStr = context
|
|
? context instanceof Error
|
|
? ` | Error: ${context.name}: ${context.message}`
|
|
: ` | ${JSON.stringify(context)}`
|
|
: '';
|
|
|
|
return `[${levelName}] ${timestamp} | ${message}${contextStr}`;
|
|
}
|
|
|
|
/**
|
|
* Create a logger instance with the configured log level
|
|
*/
|
|
function createLogger(): Logger {
|
|
const currentLevel = getLogLevel();
|
|
|
|
const shouldLog = (level: LogLevel): boolean => {
|
|
return level >= currentLevel;
|
|
};
|
|
|
|
return {
|
|
debug(message: string, context?: LogContext): void {
|
|
if (shouldLog(LogLevel.DEBUG)) {
|
|
console.log(formatLog(LogLevel.DEBUG, message, context));
|
|
}
|
|
},
|
|
|
|
info(message: string, context?: LogContext): void {
|
|
if (shouldLog(LogLevel.INFO)) {
|
|
console.log(formatLog(LogLevel.INFO, message, context));
|
|
}
|
|
},
|
|
|
|
warn(message: string, context?: LogContext): void {
|
|
if (shouldLog(LogLevel.WARN)) {
|
|
console.warn(formatLog(LogLevel.WARN, message, context));
|
|
}
|
|
},
|
|
|
|
error(message: string, context?: LogContext | Error): void {
|
|
if (shouldLog(LogLevel.ERROR)) {
|
|
console.error(formatLog(LogLevel.ERROR, message, context));
|
|
}
|
|
},
|
|
|
|
isLevelEnabled(level: LogLevel): boolean {
|
|
return shouldLog(level);
|
|
},
|
|
};
|
|
}
|
|
|
|
// Export singleton logger instance
|
|
export const logger = createLogger();
|
|
|
|
// Export for testing
|
|
export { getLogLevel, formatLog, createLogger };
|