All checks were successful
CI / skip-ci-check (push) Successful in 1m25s
CI / lint-and-type-check (push) Successful in 1m50s
CI / test (push) Successful in 1m54s
CI / build (push) Successful in 1m54s
CI / secret-scanning (push) Successful in 1m26s
CI / dependency-scan (push) Successful in 1m31s
CI / sast-scan (push) Successful in 2m34s
CI / workflow-summary (push) Successful in 1m23s
# Fix authentication issues and improve developer experience ## Summary This MR fixes critical authentication issues that prevented login on localhost and improves the developer experience with consolidated rebuild scripts and a working help modal keyboard shortcut. ## Problems Fixed ### 1. Authentication Issues - **UntrustedHost Error**: NextAuth v5 was rejecting localhost requests with "UntrustedHost: Host must be trusted" error - **Cookie Prefix Errors**: Cookies were being set with `__Host-` and `__Secure-` prefixes on HTTP (localhost), causing browser rejection - **MissingCSRF Error**: CSRF token cookies were not being set correctly due to cookie configuration issues ### 2. Help Modal Keyboard Shortcut - **Shift+? not working**: The help modal keyboard shortcut was not detecting the question mark key correctly ### 3. Developer Experience - **Multiple rebuild scripts**: Had several overlapping rebuild scripts that were confusing - **Unused code**: Removed unused `useSecureCookies` variable and misleading comments ## Changes Made ### Authentication Fixes (`lib/auth.ts`) - Set `trustHost: true` to fix UntrustedHost error (required for NextAuth v5) - Added explicit cookie configuration for HTTP (localhost) to prevent prefix errors: - Cookies use `secure: false` for HTTP - Cookie names without prefixes for HTTP - Let Auth.js defaults handle HTTPS (with prefixes and Secure flag) - Removed unused `useSecureCookies` variable - Simplified debug logging ### Help Modal Fix (`components/HelpModal.tsx`) - Fixed keyboard shortcut detection to properly handle Shift+? (Shift+/) - Updated help text to show correct shortcut (Shift+? instead of Ctrl+?) ### Developer Scripts - **Consolidated rebuild scripts**: Merged `CLEAN_REBUILD.sh`, `FIX_AND_RESTART.sh`, and `start-server.sh` into single `rebuild.sh` - **Added REBUILD.md**: Documentation for rebuild process - Removed redundant script files ### Code Cleanup - Removed unused `useSecureCookies` variable from `lib/auth.ts` - Removed misleading comment from `app/api/auth/[...nextauth]/route.ts` - Cleaned up verbose debug logging ## Technical Details ### Cookie Configuration The fix works by explicitly configuring cookies for HTTP environments: - **HTTP (localhost)**: Cookies without prefixes, `secure: false` - **HTTPS (production)**: Let Auth.js defaults handle (prefixes + Secure flag) This prevents NextAuth v5 from auto-detecting HTTPS from proxy headers and incorrectly adding cookie prefixes. ### Keyboard Shortcut The question mark key requires Shift+/ on most keyboards. The fix now properly detects: - `event.shiftKey && event.key === "/"` - `event.key === "?"` (fallback) - `event.code === "Slash" && event.shiftKey` (additional fallback) ## Testing - ✅ Login works on localhost (http://localhost:3000) - ✅ No cookie prefix errors in browser console - ✅ No UntrustedHost errors in server logs - ✅ Help modal opens/closes with Shift+? - ✅ Rebuild script works in both dev and prod modes ## Files Changed ### Modified - `lib/auth.ts` - Authentication configuration fixes - `components/HelpModal.tsx` - Keyboard shortcut fix - `app/api/auth/[...nextauth]/route.ts` - Removed misleading comment ### Added - `rebuild.sh` - Consolidated rebuild script - `REBUILD.md` - Rebuild documentation ## Migration Notes No database migrations or environment variable changes required. The fix works with existing configuration. ## Related Issues Fixes authentication issues preventing local development and testing. Reviewed-on: #5
71 lines
1.8 KiB
TypeScript
71 lines
1.8 KiB
TypeScript
/**
|
|
* Activity logging utility for tracking user actions
|
|
* Uses structured logging with log levels for better production control
|
|
*/
|
|
|
|
import { logger } from './logger'
|
|
|
|
export interface ActivityLog {
|
|
timestamp: string
|
|
userId?: string
|
|
userEmail?: string
|
|
userRole?: string
|
|
action: string
|
|
path: string
|
|
method: string
|
|
ip?: string
|
|
details?: Record<string, unknown>
|
|
}
|
|
|
|
/**
|
|
* Log user activity with structured data
|
|
* Uses INFO level logging - can be filtered via LOG_LEVEL environment variable
|
|
*
|
|
* @param action - The action being performed (e.g., "PHOTO_UPLOAD", "GUESS_SUBMITTED")
|
|
* @param path - The request path
|
|
* @param method - The HTTP method
|
|
* @param user - Optional user object (id, email, role)
|
|
* @param details - Optional additional context data
|
|
* @param request - Optional Request object for extracting IP address
|
|
* @returns Structured activity log object
|
|
*/
|
|
export function logActivity(
|
|
action: string,
|
|
path: string,
|
|
method: string,
|
|
user?: { id: string; email: string; role: string } | null,
|
|
details?: Record<string, unknown>,
|
|
request?: Request
|
|
): ActivityLog {
|
|
const timestamp = new Date().toISOString()
|
|
const ip = request?.headers.get("x-forwarded-for") ||
|
|
request?.headers.get("x-real-ip") ||
|
|
"unknown"
|
|
|
|
const log: ActivityLog = {
|
|
timestamp,
|
|
userId: user?.id,
|
|
userEmail: user?.email,
|
|
userRole: user?.role,
|
|
action,
|
|
path,
|
|
method,
|
|
ip: ip.split(",")[0].trim(), // Get first IP if multiple
|
|
details
|
|
}
|
|
|
|
// Use structured logging with INFO level
|
|
// This allows filtering via LOG_LEVEL environment variable
|
|
logger.info(`Activity: ${action}`, {
|
|
method,
|
|
path,
|
|
userId: user?.id,
|
|
userEmail: user?.email,
|
|
userRole: user?.role,
|
|
ip: ip.split(",")[0].trim(),
|
|
...(details && { details }),
|
|
})
|
|
|
|
return log
|
|
}
|