fix: Refine CI skip logic for improved clarity and compatibility
Some checks failed
CI / skip-ci-check (pull_request) Successful in 1m19s
CI / lint-and-type-check (pull_request) Failing after 1m42s
CI / test (pull_request) Successful in 1m47s
CI / build (pull_request) Failing after 1m46s
CI / secret-scanning (pull_request) Successful in 1m21s
CI / dependency-scan (pull_request) Successful in 1m25s
CI / sast-scan (pull_request) Successful in 2m25s
CI / workflow-summary (pull_request) Successful in 1m18s

- Default to 'false' for skip output to enhance runner compatibility
- Update skip condition checks to use boolean values for consistency
- Ensure CI is only skipped when explicitly indicated in branch name or commit message
This commit is contained in:
ilia 2026-01-02 17:02:09 -05:00
parent 44cd5f5e0b
commit 4200975c78

View File

@ -11,7 +11,8 @@ jobs:
skip-ci-check: skip-ci-check:
runs-on: ubuntu-latest runs-on: ubuntu-latest
outputs: outputs:
should-skip: ${{ steps.check.outputs.skip }} # Default to 'false' if the step output is missing (some runners are picky)
should-skip: ${{ steps.check.outputs.skip || 'false' }}
steps: steps:
- name: Check out code (for commit message) - name: Check out code (for commit message)
uses: actions/checkout@v4 uses: actions/checkout@v4
@ -22,7 +23,7 @@ jobs:
id: check id: check
run: | run: |
# Default to not skipping # Default to not skipping
SKIP=0 SKIP=false
# Simple skip pattern: @skipci (case-insensitive) # Simple skip pattern: @skipci (case-insensitive)
SKIP_PATTERN="@skipci" SKIP_PATTERN="@skipci"
@ -42,14 +43,14 @@ jobs:
# Check branch name (case-insensitive) # Check branch name (case-insensitive)
if echo "$BRANCH_NAME" | grep -qiF "$SKIP_PATTERN"; then if echo "$BRANCH_NAME" | grep -qiF "$SKIP_PATTERN"; then
echo "Skipping CI: branch name contains '$SKIP_PATTERN'" echo "Skipping CI: branch name contains '$SKIP_PATTERN'"
SKIP=1 SKIP=true
fi fi
# Check commit message (case-insensitive) # Check commit message (case-insensitive)
if [ $SKIP -eq 0 ] && [ -n "$COMMIT_MSG" ]; then if [ "$SKIP" = "false" ] && [ -n "$COMMIT_MSG" ]; then
if echo "$COMMIT_MSG" | grep -qiF "$SKIP_PATTERN"; then if echo "$COMMIT_MSG" | grep -qiF "$SKIP_PATTERN"; then
echo "Skipping CI: commit message contains '$SKIP_PATTERN'" echo "Skipping CI: commit message contains '$SKIP_PATTERN'"
SKIP=1 SKIP=true
fi fi
fi fi
@ -63,7 +64,7 @@ jobs:
lint-and-type-check: lint-and-type-check:
needs: skip-ci-check needs: skip-ci-check
runs-on: ubuntu-latest runs-on: ubuntu-latest
if: &should_run ${{ needs.skip-ci-check.outputs.should-skip != '1' }} if: &should_run ${{ needs.skip-ci-check.outputs.should-skip != 'true' }}
container: container:
image: node:20-bullseye image: node:20-bullseye
steps: steps: