refactor: Enhance cookie handling and error management in authentication
Some checks failed
CI / skip-ci-check (pull_request) Successful in 1m23s
CI / lint-and-type-check (pull_request) Failing after 1m44s
CI / test (pull_request) Successful in 1m52s
CI / build (pull_request) Successful in 1m52s
CI / secret-scanning (pull_request) Successful in 1m24s
CI / dependency-scan (pull_request) Successful in 1m29s
CI / sast-scan (pull_request) Successful in 2m29s
CI / workflow-summary (pull_request) Successful in 1m22s

- Updated `proxy.ts` to explicitly define cookie names based on the request protocol, improving clarity in cookie management.
- Refactored `auth.ts` to always throw an error for missing `NEXTAUTH_SECRET` at runtime, ensuring critical configuration is validated consistently.
This commit is contained in:
ilia 2026-01-04 22:15:47 -05:00
parent 9c4db74fd1
commit 19d5b7ef99
2 changed files with 7 additions and 10 deletions

View File

@ -9,13 +9,8 @@ import { logger } from "./logger"
function getNextAuthSecret(): string {
const secret = process.env.NEXTAUTH_SECRET
if (!secret) {
// Only throw in non-build contexts (runtime)
// During build, Next.js might not have env vars available
if (process.env.NEXT_PHASE !== "phase-production-build") {
throw new Error("NEXTAUTH_SECRET is not set. Define it to enable authentication.")
}
// Return a placeholder during build - will fail at runtime if not set
return "build-time-placeholder"
// Always throw at runtime - this is a critical configuration error
throw new Error("NEXTAUTH_SECRET is not set. Define it to enable authentication.")
}
return secret
}

View File

@ -13,12 +13,14 @@ export async function proxy(request: NextRequest) {
// Get token (works in Edge runtime)
// For HTTPS, NextAuth adds __Secure- prefix automatically
// Don't specify cookieName - let getToken auto-detect the correct cookie name
// It will automatically look for both prefixed and non-prefixed versions
// getToken should handle the prefix, but we specify the base name
const isHttps = request.url.startsWith("https://")
const cookieName = isHttps ? `__Secure-authjs.session-token` : `authjs.session-token`
const token = await getToken({
req: request,
secret: process.env.NEXTAUTH_SECRET,
// Don't specify cookieName - getToken will auto-detect __Secure- prefix for HTTPS
cookieName: cookieName,
})
// User activity logging - track all page visits and API calls