Gemini api key issue (#204)

* uggo ternary fix

* fix ai studio url

* service returns a 403 if unauthed

* pass validation correctly

* fix response format

* Update orchestrator/src/client/pages/settings/utils.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix nested ternaries client

* server fix

* Address PR #204 review feedback and stabilize CI

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

extractors/adzuna/src/main.ts

@@ -1,5 +1,6 @@
 import { mkdir, writeFile } from "node:fs/promises";
 import { dirname, join } from "node:path";
+import { parseSearchTerms } from "job-ops-shared/utils/search-terms";
 import {
   toNumberOrNull,
   toStringOrNull,
@@ -7,6 +8,7 @@ import {
 
 const API_BASE = "https://api.adzuna.com/v1/api";
 const JOBOPS_PROGRESS_PREFIX = "JOBOPS_PROGRESS ";
+const DEFAULT_SEARCH_TERM = "web developer";
 
 type AdzunaCompany = { display_name?: unknown };
 type AdzunaLocation = { display_name?: unknown };
@@ -44,36 +46,6 @@ function parsePositiveInt(input: string | undefined, fallback: number): number {
   return parsed;
 }
 
-function parseSearchTerms(raw: string | undefined): string[] {
-  if (!raw || raw.trim().length === 0) return ["web developer"];
-
-  const trimmed = raw.trim();
-  if (trimmed.startsWith("[")) {
-    try {
-      const parsed = JSON.parse(trimmed) as unknown;
-      if (Array.isArray(parsed)) {
-        const terms = parsed
-          .map((value) => toStringOrNull(value))
-          .filter((value): value is string => value !== null);
-        if (terms.length > 0) return terms;
-      }
-    } catch {
-      // Fall through to delimiter parsing.
-    }
-  }
-
-  const delimiter = trimmed.includes("|")
-    ? "|"
-    : trimmed.includes("\n")
-      ? "\n"
-      : ",";
-  const terms = trimmed
-    .split(delimiter)
-    .map((value) => value.trim())
-    .filter(Boolean);
-  return terms.length > 0 ? terms : ["web developer"];
-}
-
 function requireEnv(name: string): string {
   const value = process.env[name]?.trim();
   if (!value) throw new Error(`Missing required environment variable: ${name}`);
@@ -167,7 +139,10 @@ async function run(): Promise<void> {
     50,
   );
   const resultsPerPage = Math.min(50, configuredResultsPerPage);
-  const searchTerms = parseSearchTerms(process.env.ADZUNA_SEARCH_TERMS);
+  const searchTerms = parseSearchTerms(
+    process.env.ADZUNA_SEARCH_TERMS,
+    DEFAULT_SEARCH_TERM,
+  );
   const outputJson =
     process.env.ADZUNA_OUTPUT_JSON ||
     join(process.cwd(), "storage/datasets/default/jobs.json");

extractors/hiringcafe/src/main.ts

@@ -2,6 +2,7 @@ import { mkdir, writeFile } from "node:fs/promises";
 import { dirname, join } from "node:path";
 import { fileURLToPath } from "node:url";
 import { launchOptions } from "camoufox-js";
+import { parseSearchTerms } from "job-ops-shared/utils/search-terms";
 import {
   toNumberOrNull,
   toStringOrNull,
@@ -56,38 +57,6 @@ function parsePositiveInt(input: string | undefined, fallback: number): number {
   return parsed;
 }
 
-function parseSearchTerms(raw: string | undefined): string[] {
-  if (!raw || raw.trim().length === 0) return [DEFAULT_SEARCH_TERM];
-
-  const trimmed = raw.trim();
-  if (trimmed.startsWith("[")) {
-    try {
-      const parsed = JSON.parse(trimmed) as unknown;
-      if (Array.isArray(parsed)) {
-        const terms = parsed
-          .map((value) => toStringOrNull(value))
-          .filter((value): value is string => Boolean(value));
-        if (terms.length > 0) return terms;
-      }
-    } catch {
-      // Fall through to delimiter parsing.
-    }
-  }
-
-  const delimiter = trimmed.includes("|")
-    ? "|"
-    : trimmed.includes("\n")
-      ? "\n"
-      : ",";
-
-  const terms = trimmed
-    .split(delimiter)
-    .map((value) => value.trim())
-    .filter(Boolean);
-
-  return terms.length > 0 ? terms : [DEFAULT_SEARCH_TERM];
-}
-
 function encodeSearchState(searchState: unknown): string {
   const json = JSON.stringify(searchState);
   const urlEncodedJson = encodeURIComponent(json);
@@ -126,12 +95,7 @@ function formatCompensation(
   const frequency =
     toStringOrNull(processedJobData.listed_compensation_frequency) ?? "Yearly";
 
-  const amount =
-    min !== null && max !== null
-      ? `${Math.round(min)}-${Math.round(max)}`
-      : min !== null
-        ? `${Math.round(min)}+`
-        : `${Math.round(max ?? 0)}`;
+  const amount = formatCompensationAmount(min, max);
 
   const parts = [currency, amount, frequency ? `/ ${frequency}` : ""]
     .filter(Boolean)
@@ -141,6 +105,17 @@ function formatCompensation(
   return parts || undefined;
 }
 
+function formatCompensationAmount(
+  min: number | null,
+  max: number | null,
+): string {
+  if (min !== null && max !== null) {
+    return `${Math.round(min)}-${Math.round(max)}`;
+  }
+  if (min !== null) return `${Math.round(min)}+`;
+  return `${Math.round(max ?? 0)}`;
+}
+
 function mapHiringCafeJob(raw: RawHiringCafeJob): ExtractedJob | null {
   const jobInformation = asRecord(raw.job_information);
   const processed = asRecord(raw.v5_processed_job_data);
@@ -277,7 +252,10 @@ async function callHiringCafeApi(
 }
 
 async function run(): Promise<void> {
-  const searchTerms = parseSearchTerms(process.env.HIRING_CAFE_SEARCH_TERMS);
+  const searchTerms = parseSearchTerms(
+    process.env.HIRING_CAFE_SEARCH_TERMS,
+    DEFAULT_SEARCH_TERM,
+  );
   const country = normalizeCountryKey(
     process.env.HIRING_CAFE_COUNTRY ?? "united kingdom",
   );