From e6563e74c3452b2f89ee703685a8043e32e092a4 Mon Sep 17 00:00:00 2001 From: Shaheer Sarfaraz <53654735+DaKheera47@users.noreply.github.com> Date: Sun, 15 Feb 2026 18:44:28 +0000 Subject: [PATCH] Add visual feedback for Move to Ready action (#165) * feat(orchestrator): add visual feedback when moving jobs to Ready - Added `toast.message("Moving job to Ready...")` in `OrchestratorPage.tsx` for single item keyboard shortcut action. - Added `toast.message("Moving jobs to Ready...")` in `useBulkJobSelection.ts` for bulk `move_to_ready` action. - Updated `OrchestratorPage.test.tsx` to verify the toast notification. This addresses the issue where pressing 'R' provided no visual feedback until the action completed. * fix(orchestrator): remove accidental db files Removed `orchestrator/data/jobs.db`, `orchestrator/data/jobs.db-shm`, and `orchestrator/data/jobs.db-wal` which were accidentally created during testing. * fix(orchestrator): remove accidental root sqlite.db Removed `orchestrator/sqlite.db` which was also accidentally created. --- orchestrator/src/client/pages/OrchestratorPage.test.tsx | 1 + orchestrator/src/client/pages/OrchestratorPage.tsx | 1 + .../src/client/pages/orchestrator/useBulkJobSelection.ts | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/orchestrator/src/client/pages/OrchestratorPage.test.tsx b/orchestrator/src/client/pages/OrchestratorPage.test.tsx index 1716f67..a47fcf0 100644 --- a/orchestrator/src/client/pages/OrchestratorPage.test.tsx +++ b/orchestrator/src/client/pages/OrchestratorPage.test.tsx @@ -932,6 +932,7 @@ describe("OrchestratorPage", () => { pressKey("r"); await waitFor(() => { + expect(toast.message).toHaveBeenCalledWith("Moving job to Ready..."); // Mock useOrchestratorData returns selectedJob as job-1 always expect(api.processJob).toHaveBeenCalledWith("job-1"); }); diff --git a/orchestrator/src/client/pages/OrchestratorPage.tsx b/orchestrator/src/client/pages/OrchestratorPage.tsx index 52900f3..de86dc3 100644 --- a/orchestrator/src/client/pages/OrchestratorPage.tsx +++ b/orchestrator/src/client/pages/OrchestratorPage.tsx @@ -464,6 +464,7 @@ export const OrchestratorPage: React.FC = () => { shortcutActionInFlight.current = true; const jobId = selectedJob.id; + toast.message("Moving job to Ready..."); api .processJob(jobId) diff --git a/orchestrator/src/client/pages/orchestrator/useBulkJobSelection.ts b/orchestrator/src/client/pages/orchestrator/useBulkJobSelection.ts index b76bbc5..42a2401 100644 --- a/orchestrator/src/client/pages/orchestrator/useBulkJobSelection.ts +++ b/orchestrator/src/client/pages/orchestrator/useBulkJobSelection.ts @@ -112,6 +112,10 @@ export function useBulkJobSelection({ const selectedAtStartSet = new Set(selectedAtStart); try { setBulkActionInFlight(action); + if (action === "move_to_ready") { + toast.message("Moving jobs to Ready..."); + } + const result = await api.bulkJobAction({ action, jobIds: selectedAtStart,