From b02dac5fe82e00c3d7040d8dcd3225cff0a8a5fc Mon Sep 17 00:00:00 2001 From: Shaheer Sarfaraz <53654735+DaKheera47@users.noreply.github.com> Date: Sat, 31 Jan 2026 23:20:05 +0000 Subject: [PATCH] Fix for level 1 being added to skills (#73) * single commit fix! * fix tests! --- .../src/server/services/pdf-skills-validation.test.ts | 2 +- orchestrator/src/server/services/pdf.ts | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/orchestrator/src/server/services/pdf-skills-validation.test.ts b/orchestrator/src/server/services/pdf-skills-validation.test.ts index ab974a3..5324277 100644 --- a/orchestrator/src/server/services/pdf-skills-validation.test.ts +++ b/orchestrator/src/server/services/pdf-skills-validation.test.ts @@ -243,7 +243,7 @@ describe("PDF Service Skills Validation", () => { expect(newSkill.description).toBe(""); // Optional but good to check expect(newSkill.id).toBeDefined(); - expect(newSkill.level).toBe(1); + expect(newSkill.level).toBe(0); // Check "Existing Skill" - should preserve existing fields if not overwritten? // In the implementation, we look up existing. diff --git a/orchestrator/src/server/services/pdf.ts b/orchestrator/src/server/services/pdf.ts index 5a5c3ce..d734db4 100644 --- a/orchestrator/src/server/services/pdf.ts +++ b/orchestrator/src/server/services/pdf.ts @@ -117,8 +117,8 @@ export async function generatePdf( const { email, password, baseUrl } = await getCredentials(); const client = new RxResumeClient(baseUrl); - // Read base resume from profile (fetches from v4 API if configured) - const baseResume = JSON.parse(JSON.stringify(await getProfile())); + // Read base resume from profile (fetches from v4 API if configured, force fetch) + const baseResume = JSON.parse(JSON.stringify(await getProfile(true))); // Sanitize skills: Ensure all skills have required schema fields (visible, description, id, level, keywords) // This fixes issues where the base JSON uses a shorthand format (missing required fields) @@ -193,7 +193,7 @@ export async function generatePdf( level: newSkill.level !== undefined ? (newSkill.level as number) - : ((existing?.level as number | undefined) ?? 1), + : ((existing?.level as number | undefined) ?? 0), keywords: (newSkill.keywords as string[]) || (existing?.keywords as string[]) ||